PRESUBMIT: Make BUG= field mandatory.

PRESUBMIT: Make BUG= field mandatory.

Also show a descriptive error message if BUG= field is missing.

BUG=webrtc:6326
NOTRY=True
TESTED=Verified the presubmit error using this very same CL (but with BUG= left empty).

Committed: https://crrev.com/d1e26a9bc14614a708bc71d9ba52ce191e406486
Cr-Commit-Position: refs/heads/master@{#14291}

[kjellander_webrtc, 2016-09-08 07:33:59]

Description was changed from

==========
PRESUBMIT: Make BUG= field mandatory.

Also show a descriptive error message if BUG= field is missing.

BUG=
==========

to

==========
PRESUBMIT: Make BUG= field mandatory.

Also show a descriptive error message if BUG= field is missing.

BUG=webrtc:6326
TESTED=Verified the presubmit error using this very same CL (but with BUG= left
empty).
==========

[kjellander_webrtc, 2016-09-08 07:33:59]

kjellander@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[kjellander_webrtc, 2016-09-08 07:34:06]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-09-08 07:36:36]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-09-08 07:37:03]

As discussed with Anatoli and Chris, see referenced bug for more info.

[phoglund, 2016-09-08 07:45:01]

Arguably we should have some way of bypassing this (BUG=None), but maybe that
was the old behavior? I think bypasses are nice in many situations, but then we
need to build a culture that it should only be used in special circumstances and
under responsibility (like TBRs etc). Isn't a presubmit warning enough here?

[kjellander_webrtc, 2016-09-08 08:01:00]

On 2016/09/08 07:45:01, phoglund wrote:
> Arguably we should have some way of bypassing this (BUG=None), but maybe that
> was the old behavior? I think bypasses are nice in many situations, but then
we
> need to build a culture that it should only be used in special circumstances
and
> under responsibility (like TBRs etc). Isn't a presubmit warning enough here?

Right, BUG=None is bypassing this check easily, but BUG= is the default from the
template, and only displays a warning (that nobody reads) and the presubmit
trybot happily submits the CL.
Talk to Anatoli and Chris to see how many CLs are missing bug references -
they're a lot.

[phoglund, 2016-09-08 08:42:46]

On 2016/09/08 08:01:00, kjellander_webrtc wrote:
> On 2016/09/08 07:45:01, phoglund wrote:
> > Arguably we should have some way of bypassing this (BUG=None), but maybe
that
> > was the old behavior? I think bypasses are nice in many situations, but then
> we
> > need to build a culture that it should only be used in special circumstances
> and
> > under responsibility (like TBRs etc). Isn't a presubmit warning enough here?
> 
> Right, BUG=None is bypassing this check easily, but BUG= is the default from
the
> template, and only displays a warning (that nobody reads) and the presubmit
> trybot happily submits the CL.
> Talk to Anatoli and Chris to see how many CLs are missing bug references -
> they're a lot.

Ok, so this change forces you to type something in the bug field, but None is
acceptable?

[kjellander_webrtc, 2016-09-08 09:04:43]

On 2016/09/08 08:42:46, phoglund wrote:
> On 2016/09/08 08:01:00, kjellander_webrtc wrote:
> > On 2016/09/08 07:45:01, phoglund wrote:
> > > Arguably we should have some way of bypassing this (BUG=None), but maybe
> that
> > > was the old behavior? I think bypasses are nice in many situations, but
then
> > we
> > > need to build a culture that it should only be used in special
circumstances
> > and
> > > under responsibility (like TBRs etc). Isn't a presubmit warning enough
here?
> > 
> > Right, BUG=None is bypassing this check easily, but BUG= is the default from
> the
> > template, and only displays a warning (that nobody reads) and the presubmit
> > trybot happily submits the CL.
> > Talk to Anatoli and Chris to see how many CLs are missing bug references -
> > they're a lot.
> 
> Ok, so this change forces you to type something in the bug field, but None is
> acceptable?

Yeah, this change essentially just changes the informative message into a
blocking Error for the presubmit.
The informative message triggered too if you left it out of just had it empty,
but I figure nobody reads those.

None will make it go away, yes.

[phoglund, 2016-09-08 09:44:33]

On 2016/09/08 09:04:43, kjellander_webrtc wrote:
> On 2016/09/08 08:42:46, phoglund wrote:
> > On 2016/09/08 08:01:00, kjellander_webrtc wrote:
> > > On 2016/09/08 07:45:01, phoglund wrote:
> > > > Arguably we should have some way of bypassing this (BUG=None), but maybe
> > that
> > > > was the old behavior? I think bypasses are nice in many situations, but
> then
> > > we
> > > > need to build a culture that it should only be used in special
> circumstances
> > > and
> > > > under responsibility (like TBRs etc). Isn't a presubmit warning enough
> here?
> > > 
> > > Right, BUG=None is bypassing this check easily, but BUG= is the default
from
> > the
> > > template, and only displays a warning (that nobody reads) and the
presubmit
> > > trybot happily submits the CL.
> > > Talk to Anatoli and Chris to see how many CLs are missing bug references -
> > > they're a lot.
> > 
> > Ok, so this change forces you to type something in the bug field, but None
is
> > acceptable?
> 
> Yeah, this change essentially just changes the informative message into a
> blocking Error for the presubmit.
> The informative message triggered too if you left it out of just had it empty,
> but I figure nobody reads those.
> 
> None will make it go away, yes.

ok, lgtm

[kjellander_webrtc, 2016-09-08 10:07:26]

kjellander@webrtc.org changed reviewers:
+ anatolid@webrtc.org

[kjellander_webrtc, 2016-09-08 10:07:27]

anatolid@: should we submit this now or wait?

[kjellander_webrtc, 2016-09-15 11:29:50]

Description was changed from

==========
PRESUBMIT: Make BUG= field mandatory.

Also show a descriptive error message if BUG= field is missing.

BUG=webrtc:6326
TESTED=Verified the presubmit error using this very same CL (but with BUG= left
empty).
==========

to

==========
PRESUBMIT: Make BUG= field mandatory.

Also show a descriptive error message if BUG= field is missing.

BUG=webrtc:6326
NOTRY=True
TESTED=Verified the presubmit error using this very same CL (but with BUG= left
empty).
==========

[kjellander_webrtc, 2016-09-19 15:02:08]

On 2016/09/08 10:07:27, kjellander_webrtc wrote:
> anatolid@: should we submit this now or wait?

Submitting now.

[kjellander_webrtc, 2016-09-19 15:02:11]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-09-19 15:02:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-19 15:11:18]

Description was changed from

==========
PRESUBMIT: Make BUG= field mandatory.

Also show a descriptive error message if BUG= field is missing.

BUG=webrtc:6326
NOTRY=True
TESTED=Verified the presubmit error using this very same CL (but with BUG= left
empty).
==========

to

==========
PRESUBMIT: Make BUG= field mandatory.

Also show a descriptive error message if BUG= field is missing.

BUG=webrtc:6326
NOTRY=True
TESTED=Verified the presubmit error using this very same CL (but with BUG= left
empty).
==========

[commit-bot: I haz the power, 2016-09-19 15:11:20]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-09-19 15:11:24]

Description was changed from

==========
PRESUBMIT: Make BUG= field mandatory.

Also show a descriptive error message if BUG= field is missing.

BUG=webrtc:6326
NOTRY=True
TESTED=Verified the presubmit error using this very same CL (but with BUG= left
empty).
==========

to

==========
PRESUBMIT: Make BUG= field mandatory.

Also show a descriptive error message if BUG= field is missing.

BUG=webrtc:6326
NOTRY=True
TESTED=Verified the presubmit error using this very same CL (but with BUG= left
empty).

Committed: https://crrev.com/d1e26a9bc14614a708bc71d9ba52ce191e406486
Cr-Commit-Position: refs/heads/master@{#14291}
==========

[commit-bot: I haz the power, 2016-09-19 15:11:25]

Patchset 1 (id:??) landed as
https://crrev.com/d1e26a9bc14614a708bc71d9ba52ce191e406486
Cr-Commit-Position: refs/heads/master@{#14291}