Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2321783003: GN: Move audio_coding to public_deps in voice engine (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Move audio_coding to public_deps in voice engine audio_coding should be in public_deps, in order to a define used by voe_output_test.ccto be exported, as is done in GYP NOTRY=True BUG=webrtc:5949 Committed: https://crrev.com/53cec04f5ce7cdd18648968cedf1628e535f4e83 Cr-Commit-Position: refs/heads/master@{#14161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/voice_engine/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-09 07:39:16 UTC) #2
kjellander_webrtc
lgtm but I'm adding solenberg@ in case he wants to change this behavior in GYP+GN.
4 years, 3 months ago (2016-09-09 08:39:43 UTC) #4
the sun
lgtm should be changed eventually, but I think it's more important right now to homogenize ...
4 years, 3 months ago (2016-09-09 12:13:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2321783003/1
4 years, 3 months ago (2016-09-09 12:24:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 12:32:16 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 12:32:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53cec04f5ce7cdd18648968cedf1628e535f4e83
Cr-Commit-Position: refs/heads/master@{#14161}

Powered by Google App Engine
This is Rietveld 408576698