webrtc/modules/rtp_rtcp/include/rtp_cvo.h - Issue 2320913003: Reland of Ignore Camera and Flip bits in CVO when parsing video rotation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_cvo.h

Issue 2320913003: Reland of Ignore Camera and Flip bits in CVO when parsing video rotation (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/include/rtp_cvo.h

diff --git a/webrtc/modules/rtp_rtcp/include/rtp_cvo.h b/webrtc/modules/rtp_rtcp/include/rtp_cvo.h

index 5d5c995cd5fca94c70cf698622988ac79371e56d..b60b06e5df4fd0c7d7b2f978274735f4a33a5385 100644

--- a/webrtc/modules/rtp_rtcp/include/rtp_cvo.h

+++ b/webrtc/modules/rtp_rtcp/include/rtp_cvo.h

@@ -34,8 +34,10 @@

return 0;

}

-inline VideoRotation ConvertCVOByteToVideoRotation(uint8_t rotation) {

- switch (rotation) {

+inline VideoRotation ConvertCVOByteToVideoRotation(uint8_t cvo_byte) {

+ // CVO byte: |0 0 0 0 C F R R|.

+ const uint8_t rotation_bits = cvo_byte & 0x3;

+ switch (rotation_bits) {

case 0:

return kVideoRotation_0;

case 1:

« no previous file with comments | « webrtc/common_types.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc » ('j') | no next file with comments »