Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2320873003: A more useful gyp_flag_compare script (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

A more useful gyp_flag_compare script NOTRY=True BUG=webrtc:5949 Committed: https://crrev.com/4e869e9f34263e2d3cf6c54475dec732438fd232 Cr-Commit-Position: refs/heads/master@{#14123}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use parentheses instead of \ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M tools/gyp_flag_compare.py View 1 6 chunks +27 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-08 08:16:13 UTC) #3
kjellander_webrtc
lgtm with comment addressed. https://codereview.webrtc.org/2320873003/diff/1/tools/gyp_flag_compare.py File tools/gyp_flag_compare.py (right): https://codereview.webrtc.org/2320873003/diff/1/tools/gyp_flag_compare.py#newcode447 tools/gyp_flag_compare.py:447: if difference_type in missing_in_gyp and\ ...
4 years, 3 months ago (2016-09-08 09:51:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2320873003/20001
4 years, 3 months ago (2016-09-08 09:54:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 10:12:20 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 10:12:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e869e9f34263e2d3cf6c54475dec732438fd232
Cr-Commit-Position: refs/heads/master@{#14123}

Powered by Google App Engine
This is Rietveld 408576698