Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2320723007: Revert of Only expose gflags target in non-Chromium and non-fuzzer builds. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Only expose gflags target in non-Chromium and non-fuzzer builds. (patchset #1 id:40001 of https://codereview.webrtc.org/2321963002/ ) Reason for revert: Eh, I forgot to run the libfuzzer trybot :( broke in the main waterfall. Original issue's description: > Only expose gflags target in non-Chromium and non-fuzzer builds. > > Since gflags is not present in Chromium nor the libfuzzer infrastructure, > we have to ensure we don't accidentally depend on it in WebRTC code > that is used in such places. > > BUG=chromium:645069 > NOTRY=True > > Committed: https://crrev.com/9365338db2e0505d6e5f8ea62fa8fe2c45ea8f74 > Cr-Commit-Position: refs/heads/master@{#14145} TBR=ehmaldonado@webrtc.org,henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:645069 Committed: https://crrev.com/b0afd97d6e86fcbff946b0244f465739159fce21 Cr-Commit-Position: refs/heads/master@{#14149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -62 lines) Patch
M third_party/gflags/BUILD.gn View 1 chunk +55 lines, -62 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_webrtc
Created Revert of Only expose gflags target in non-Chromium and non-fuzzer builds.
4 years, 3 months ago (2016-09-09 07:27:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2320723007/1
4 years, 3 months ago (2016-09-09 07:27:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 07:27:32 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b0afd97d6e86fcbff946b0244f465739159fce21 Cr-Commit-Position: refs/heads/master@{#14149}
4 years, 3 months ago (2016-09-09 07:27:42 UTC) #6
hlundin-webrtc
4 years, 3 months ago (2016-09-09 07:46:00 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698