Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2320703003: Remove handling unused rtcp packets. (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, åsapersson
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove handling unused rtcp packets. App, ExtendedJitterReport and VoipMetric in ExtenedReports are not used when received (no callbacks, no state change), so removed. BUG=webrtc:5260 Committed: https://crrev.com/17366bc09081fae148d1f95941eeedb584a2a2a2 Cr-Commit-Position: refs/heads/master@{#14204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -167 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 3 chunks +0 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 5 chunks +0 lines, -96 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 3 chunks +0 lines, -12 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.cc View 2 chunks +2 lines, -38 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
danilchap
4 years, 3 months ago (2016-09-08 07:41:59 UTC) #3
sprang_webrtc
Also, no tests I guess? :) lgtm
4 years, 3 months ago (2016-09-12 07:59:53 UTC) #4
danilchap
On 2016/09/12 07:59:53, språng wrote: > Also, no tests I guess? :) > lgtm Because ...
4 years, 3 months ago (2016-09-12 08:37:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2320703003/1
4 years, 3 months ago (2016-09-14 06:53:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 06:54:51 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 06:55:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17366bc09081fae148d1f95941eeedb584a2a2a2
Cr-Commit-Position: refs/heads/master@{#14204}

Powered by Google App Engine
This is Rietveld 408576698