Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2320603002: Make rtcp parsing implementation private in RtcpReceiver (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make rtcp parsing implementation private in RtcpReceiver: Function just for Parse and for Callbacks moved to private section. All handles moved from protected to private section. BUG=webrtc:5260 R=sprang@webrtc.org Committed: https://crrev.com/faf708e238c7b43a732fbebf79ac9298b4b95a95 Cr-Commit-Position: refs/heads/master@{#14181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 3 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
danilchap
4 years, 3 months ago (2016-09-08 07:34:45 UTC) #3
sprang_webrtc
lgtm
4 years, 3 months ago (2016-09-12 07:56:02 UTC) #4
danilchap
Committed patchset #1 (id:1) manually as faf708e238c7b43a732fbebf79ac9298b4b95a95 (presubmit successful).
4 years, 3 months ago (2016-09-12 08:31:31 UTC) #7
danilchap
4 years, 3 months ago (2016-09-12 08:40:26 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2332673003/ by danilchap@webrtc.org.

The reason for reverting is: Breaks fuzzer compilation..

Powered by Google App Engine
This is Rietveld 408576698