Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2320113002: Revert of Don't use VoE legacy APIs in force_mic_volume_max tool. (Closed)

Created:
4 years, 3 months ago by the sun
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Don't use VoE legacy APIs in force_mic_volume_max tool. (patchset #5 id:80001 of https://codereview.webrtc.org/2268183007/ ) Reason for revert: Breaks Chromium FYI bots because of link issue Original issue's description: > Don't use VoE legacy APIs in force_mic_volume_max tool. > > BUG=webrtc:4690 > > Committed: https://crrev.com/ae9f2bdcef7f3a338ece6f57744c8c8f74d15483 > Cr-Commit-Position: refs/heads/master@{#14135} TBR=henrika@webrtc.org,phoglund@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4690 Committed: https://crrev.com/13eef7859341506382f5655fa2c310778dbc89ad Cr-Commit-Position: refs/heads/master@{#14137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -34 lines) Patch
M webrtc/tools/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/tools/force_mic_volume_max/force_mic_volume_max.cc View 1 chunk +21 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
the sun
Created Revert of Don't use VoE legacy APIs in force_mic_volume_max tool.
4 years, 3 months ago (2016-09-08 14:30:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2320113002/1
4 years, 3 months ago (2016-09-08 14:30:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 14:30:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13eef7859341506382f5655fa2c310778dbc89ad Cr-Commit-Position: refs/heads/master@{#14137}
4 years, 3 months ago (2016-09-08 14:31:10 UTC) #6
henrika_webrtc
4 years, 3 months ago (2016-09-08 14:32:50 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698