Adding DTX controller to audio network adaptor.

Adding DTX controller to audio network adaptor.

BUG=webrtc:6303
Committed: https://crrev.com/186cd0651249382e33f0f37e679428f51c9bee4f
Cr-Commit-Position: refs/heads/master@{#14260}

[minyue-webrtc, 2016-09-08 13:27:02]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 13:27:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[minyue-webrtc, 2016-09-08 13:28:04]

Description was changed from

==========
adding copyright


reformat


working


half way


half way

BUG=
==========

to

==========
Adding DTX controller in audio network adaptor.

BUG=webrtc:6303
==========

[minyue-webrtc, 2016-09-08 13:28:04]

minyue@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, michaelt@webrtc.org

[minyue-webrtc, 2016-09-08 13:28:41]

Description was changed from

==========
Adding DTX controller in audio network adaptor.

BUG=webrtc:6303
==========

to

==========
Adding DTX controller to audio network adaptor.

BUG=webrtc:6303
==========

[commit-bot: I haz the power, 2016-09-08 14:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 14:51:48]

Dry run: Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/16379)

[minyue-webrtc, 2016-09-08 14:55:56]

Hi,

Here is another controller implementation. It is fairly similar to
ChannelController.

PTAL. Thanks!

[minyue-webrtc, 2016-09-08 14:57:54]

I found an error myself

https://codereview.webrtc.org/2320093002/diff/1/webrtc/modules/audio_coding/a...
File webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller.cc
(right):

https://codereview.webrtc.org/2320093002/diff/1/webrtc/modules/audio_coding/a...
webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller.cc:22: //
Decision on |num_channels| should not have been made.
num_channels -> enable_dtx

[hlundin-webrtc, 2016-09-09 11:11:37]

Nice and clean! I have one suggestion for an additional test. Otherwise, LGTM.

https://codereview.webrtc.org/2320093002/diff/1/webrtc/modules/audio_coding/a...
File
webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc
(right):

https://codereview.webrtc.org/2320093002/diff/1/webrtc/modules/audio_coding/a...
webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc:83:

None of the tests exercise the DtxController with more than a single call to
MakeDecision. Consider adding one test where a sequence of calls are made, e.g.,
jumping back and forth over the dead-zone.

[minyue-webrtc, 2016-09-15 08:00:30]

I added a new patch set. Rebasing came in fixed, sorry for that. I highlighted
the critical changes, which are anyways small changes.

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/BUILD.gn
File webrtc/modules/BUILD.gn (right):

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/BUILD.gn#n...
webrtc/modules/BUILD.gn:35: modules_tests_resources = [
all changes in this file are due to rebasing

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:706:
"audio_network_adaptor/channel_controller.cc",
all changes in this file are due to rebasing

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
File
webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.gypi
(right):

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.gypi:17:
'channel_controller.cc',
all changes in this file are due to rebasing

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
File
webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc
(right):

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc:25:
std::unique_ptr<DtxController> CreateController(int initial_dtx_enabled) {
inspired by other CL, I did further simplification on the test

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc:74:
TEST(DtxControllerTest, CheckBehaviorOnChangingUplinkBandwidth) {
added this test to cover continuous changes of network condition

[hlundin-webrtc, 2016-09-15 11:05:48]

lgtm

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
File
webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc
(right):

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc:25:
std::unique_ptr<DtxController> CreateController(int initial_dtx_enabled) {
On 2016/09/15 08:00:30, minyue-webrtc wrote:
> inspired by other CL, I did further simplification on the test

Improved!

https://codereview.webrtc.org/2320093002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc:74:
TEST(DtxControllerTest, CheckBehaviorOnChangingUplinkBandwidth) {
On 2016/09/15 08:00:30, minyue-webrtc wrote:
> added this test to cover continuous changes of network condition

Good!

[michaelt, 2016-09-16 08:46:18]

lgtm

[minyue-webrtc, 2016-09-16 08:47:23]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2016-09-16 08:47:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-16 08:48:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 08:48:36]

Try jobs failed on following builders:
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)
  ios64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_dbg/builds/565)
  ios64_gyp_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_rel/builds/568)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/16864)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/13135)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/17687)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gyp_dbg/builds/670)
  mac_gyp_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gyp_rel/builds/673)

[minyue-webrtc, 2016-09-16 09:19:22]

Patchset #3 (id:40001) has been deleted

[minyue-webrtc, 2016-09-16 09:25:51]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-09-16 09:25:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, michaelt@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2320093002/#ps60001 (title:
"rebasing")

[commit-bot: I haz the power, 2016-09-16 09:26:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-16 11:26:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 11:26:48]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[minyue-webrtc, 2016-09-16 11:29:28]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2016-09-16 11:29:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-16 12:54:41]

Description was changed from

==========
Adding DTX controller to audio network adaptor.

BUG=webrtc:6303
==========

to

==========
Adding DTX controller to audio network adaptor.

BUG=webrtc:6303
==========

[commit-bot: I haz the power, 2016-09-16 12:54:42]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-16 12:54:50]

Description was changed from

==========
Adding DTX controller to audio network adaptor.

BUG=webrtc:6303
==========

to

==========
Adding DTX controller to audio network adaptor.

BUG=webrtc:6303

Committed: https://crrev.com/186cd0651249382e33f0f37e679428f51c9bee4f
Cr-Commit-Position: refs/heads/master@{#14260}
==========

[commit-bot: I haz the power, 2016-09-16 12:54:51]

Patchset 3 (id:??) landed as
https://crrev.com/186cd0651249382e33f0f37e679428f51c9bee4f
Cr-Commit-Position: refs/heads/master@{#14260}