Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2319723004:
Change owner of webrtc/test/channel_transport. (Closed)
|
Created:
4 years, 3 months ago by Henrik Grunell WebRTC Modified:
4 years, 3 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionChange owner of webrtc/test/channel_transport to solenberg@.
I'm not (longer) familiar with this code.
NOTRY=true
Committed: https://crrev.com/0e62f2bebeb09f4c952009922a7ce46b63db8648
Cr-Commit-Position: refs/heads/master@{#14140}
Patch Set 1 #Patch Set 2 : Change owner. #Messages
Total messages: 24 (14 generated)
Description was changed from ========== Remove webrtc/test/channel_transport/OWNERS. I'm not (longer) familiar with this code. ========== to ========== Remove webrtc/test/channel_transport/OWNERS. I'm not (longer) familiar with this code. ==========
henrikg@webrtc.org changed reviewers: + phoglund@webrtc.org, solenberg@webrtc.org
OK to remove this (and fall back on parent owners), or should someone specific own this?
On 2016/09/08 12:18:27, Henrik Grunell (webrtc) wrote: > OK to remove this (and fall back on parent owners), or should someone specific > own this? I can own it. Only used in VoE tests AFAICT.
Description was changed from ========== Remove webrtc/test/channel_transport/OWNERS. I'm not (longer) familiar with this code. ========== to ========== Change owner of webrtc/test/channel_transport. I'm not (longer) familiar with this code. ==========
Description was changed from ========== Change owner of webrtc/test/channel_transport. I'm not (longer) familiar with this code. ========== to ========== Change owner of webrtc/test/channel_transport to solenberg@. I'm not (longer) familiar with this code. ==========
On 2016/09/08 12:28:08, the sun wrote: > On 2016/09/08 12:18:27, Henrik Grunell (webrtc) wrote: > > OK to remove this (and fall back on parent owners), or should someone specific > > own this? > > I can own it. Only used in VoE tests AFAICT. OK. I changed owner to you instead.
The CQ bit was checked by henrikg@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
lgtm
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/16381)
The CQ bit was checked by henrikg@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/16388)
Description was changed from ========== Change owner of webrtc/test/channel_transport to solenberg@. I'm not (longer) familiar with this code. ========== to ========== Change owner of webrtc/test/channel_transport to solenberg@. I'm not (longer) familiar with this code. NOTRY=true ==========
The CQ bit was checked by henrikg@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Change owner of webrtc/test/channel_transport to solenberg@. I'm not (longer) familiar with this code. NOTRY=true ========== to ========== Change owner of webrtc/test/channel_transport to solenberg@. I'm not (longer) familiar with this code. NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Change owner of webrtc/test/channel_transport to solenberg@. I'm not (longer) familiar with this code. NOTRY=true ========== to ========== Change owner of webrtc/test/channel_transport to solenberg@. I'm not (longer) familiar with this code. NOTRY=true Committed: https://crrev.com/0e62f2bebeb09f4c952009922a7ce46b63db8648 Cr-Commit-Position: refs/heads/master@{#14140} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0e62f2bebeb09f4c952009922a7ce46b63db8648 Cr-Commit-Position: refs/heads/master@{#14140} |
