Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 2319583005: Moved webrtc/test/channel_transport/ into webrtc/voice_engine/test/ (Closed)

Created:
4 years, 3 months ago by the sun
Modified:
4 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved webrtc/test/channel_transport/ into webrtc/voice_engine/test/ Only used in VoE tests so I'm moving it in under voice_engine/ until we've removed its usage and can deprecate. Note: submitting this with PRESUBMIT=false because the files do not adhere to style guide conventions and I'd rather change that in a separate CL. BUG= NOPRESUBMIT=true Committed: https://crrev.com/ade2a038a9290ee0c85d8c682eba5447aca943cd Committed: https://crrev.com/ba56b6c7d23fc4a818e7609ffa07b4693712f43e Cr-Original-Commit-Position: refs/heads/master@{#14191} Cr-Commit-Position: refs/heads/master@{#14198}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : build problem on iOS #

Patch Set 4 : build error on win_x64 #

Total comments: 1

Patch Set 5 : reviewer comment #

Patch Set 6 : rebase #

Patch Set 7 : and really fix win x64 build issue #

Patch Set 8 : move channel_transport in under include_tests in .gyp #

Patch Set 9 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -8188 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 4 chunks +0 lines, -66 lines 0 comments Download
D webrtc/test/channel_transport/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/test/channel_transport/channel_transport.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/test/channel_transport/channel_transport.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/test/channel_transport/traffic_control_win.h View 1 chunk +0 lines, -99 lines 0 comments Download
D webrtc/test/channel_transport/traffic_control_win.cc View 1 chunk +0 lines, -252 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket2_manager_win.h View 1 chunk +0 lines, -162 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket2_manager_win.cc View 1 chunk +0 lines, -608 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket2_win.h View 1 chunk +0 lines, -174 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket2_win.cc View 1 chunk +0 lines, -1353 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_manager_posix.h View 1 chunk +0 lines, -88 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_manager_posix.cc View 1 chunk +0 lines, -392 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_manager_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_manager_wrapper.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_manager_wrapper.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_posix.h View 1 chunk +0 lines, -94 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_posix.cc View 1 chunk +0 lines, -271 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_wrapper.h View 1 chunk +0 lines, -112 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_wrapper.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D webrtc/test/channel_transport/udp_socket_wrapper_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/test/channel_transport/udp_transport.h View 1 chunk +0 lines, -381 lines 0 comments Download
D webrtc/test/channel_transport/udp_transport_impl.h View 1 chunk +0 lines, -259 lines 0 comments Download
D webrtc/test/channel_transport/udp_transport_impl.cc View 1 chunk +0 lines, -3005 lines 0 comments Download
D webrtc/test/channel_transport/udp_transport_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M webrtc/test/test.gyp View 3 chunks +0 lines, -53 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 4 chunks +66 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_cpu_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_output_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_stress_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/voice_engine/test/channel_transport/channel_transport.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/channel_transport.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/traffic_control_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/traffic_control_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket2_manager_win.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket2_manager_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket2_win.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket2_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_manager_posix.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_manager_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_manager_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_manager_wrapper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_posix.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_posix.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_wrapper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_wrapper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_socket_wrapper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_transport.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_transport_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_transport_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + webrtc/voice_engine/test/channel_transport/udp_transport_unittest.cc View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 1 2 3 4 5 6 7 5 chunks +56 lines, -3 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 35 (19 generated)
the sun
4 years, 3 months ago (2016-09-12 08:00:26 UTC) #2
kwiberg-webrtc
lgtm https://codereview.webrtc.org/2319583005/diff/60001/webrtc/voice_engine/test/channel_transport/OWNERS File webrtc/voice_engine/test/channel_transport/OWNERS (right): https://codereview.webrtc.org/2319583005/diff/60001/webrtc/voice_engine/test/channel_transport/OWNERS#newcode1 webrtc/voice_engine/test/channel_transport/OWNERS:1: solenberg@webrtc.org Do you need this file? It seems ...
4 years, 3 months ago (2016-09-12 09:25:45 UTC) #4
the sun
On 2016/09/12 09:25:45, kwiberg-webrtc wrote: > lgtm > > https://codereview.webrtc.org/2319583005/diff/60001/webrtc/voice_engine/test/channel_transport/OWNERS > File webrtc/voice_engine/test/channel_transport/OWNERS (right): > ...
4 years, 3 months ago (2016-09-12 09:37:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2319583005/120001
4 years, 3 months ago (2016-09-12 11:41:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8277)
4 years, 3 months ago (2016-09-12 12:09:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2319583005/120001
4 years, 3 months ago (2016-09-13 07:37:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8292)
4 years, 3 months ago (2016-09-13 07:50:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2319583005/120001
4 years, 3 months ago (2016-09-13 08:10:24 UTC) #18
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-09-13 08:10:50 UTC) #20
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/ade2a038a9290ee0c85d8c682eba5447aca943cd Cr-Commit-Position: refs/heads/master@{#14191}
4 years, 3 months ago (2016-09-13 08:11:03 UTC) #22
the sun
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.webrtc.org/2336123002/ by solenberg@webrtc.org. ...
4 years, 3 months ago (2016-09-13 08:23:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2319583005/160001
4 years, 3 months ago (2016-09-13 09:53:35 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-13 11:53:56 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2319583005/160001
4 years, 3 months ago (2016-09-13 14:28:50 UTC) #31
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 3 months ago (2016-09-13 14:29:16 UTC) #33
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 14:29:27 UTC) #35
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/ba56b6c7d23fc4a818e7609ffa07b4693712f43e
Cr-Commit-Position: refs/heads/master@{#14198}

Powered by Google App Engine
This is Rietveld 408576698