Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2319123003: FilePlayer: Remove backwards compatibility stuff that we no longer need (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

FilePlayer: Remove backwards compatibility stuff that we no longer need This includes renaming NewFilePlayer to CreateFilePlayer. Committed: https://crrev.com/5b356f46bb88ba32c0250de9a75036dc2b114aef Cr-Commit-Position: refs/heads/master@{#14128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -45 lines) Patch
M webrtc/modules/utility/include/file_player.h View 2 chunks +1 line, -28 lines 0 comments Download
M webrtc/modules/utility/source/file_player.cc View 2 chunks +1 line, -10 lines 0 comments Download
M webrtc/modules/utility/source/file_player_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
This is a combination of three separate CLs, two of which you have previously LGTMed. ...
4 years, 3 months ago (2016-09-08 10:46:11 UTC) #2
ossu
lgtm
4 years, 3 months ago (2016-09-08 11:11:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2319123003/1
4 years, 3 months ago (2016-09-08 11:21:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 11:32:36 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:32:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b356f46bb88ba32c0250de9a75036dc2b114aef
Cr-Commit-Position: refs/heads/master@{#14128}

Powered by Google App Engine
This is Rietveld 408576698