Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2318173002: Remove dead code branches from P2PtransportChannel unittest. (Closed)

Created:
4 years, 3 months ago by johan
Modified:
4 years, 3 months ago
Reviewers:
honghaiz3
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sprang_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dead code branches from P2PtransportChannel unittest. BUG=None Committed: https://crrev.com/02bd5125e9a90f1516b83ce001a7262869a096ef Cr-Commit-Position: refs/heads/master@{#14299}

Patch Set 1 #

Patch Set 2 : Fix build issue and re-run git cl format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -69 lines) Patch
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 43 chunks +47 lines, -69 lines 0 comments Download

Messages

Total messages: 39 (20 generated)
johan
4 years, 3 months ago (2016-09-07 15:07:50 UTC) #2
honghaiz3
lgtm
4 years, 3 months ago (2016-09-07 15:43:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2318173002/1
4 years, 3 months ago (2016-09-07 15:49:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/14127)
4 years, 3 months ago (2016-09-07 15:53:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2318173002/20001
4 years, 3 months ago (2016-09-07 16:04:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/10788)
4 years, 3 months ago (2016-09-07 16:25:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2318173002/20001
4 years, 3 months ago (2016-09-07 16:33:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/10790)
4 years, 3 months ago (2016-09-07 16:44:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2318173002/20001
4 years, 3 months ago (2016-09-08 14:14:50 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-08 16:15:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2318173002/20001
4 years, 3 months ago (2016-09-08 19:40:17 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gyp_dbg/builds/446) win_x64_rel on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 20:25:25 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2318173002/20001
4 years, 3 months ago (2016-09-15 17:00:07 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-15 19:00:40 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2318173002/20001
4 years, 3 months ago (2016-09-19 15:26:51 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8481)
4 years, 3 months ago (2016-09-19 15:44:50 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2318173002/20001
4 years, 3 months ago (2016-09-20 07:15:03 UTC) #35
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 07:23:30 UTC) #37
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 07:23:42 UTC) #39
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02bd5125e9a90f1516b83ce001a7262869a096ef
Cr-Commit-Position: refs/heads/master@{#14299}

Powered by Google App Engine
This is Rietveld 408576698