VadCore: Allow signed multiplication overflow that we don't know how to fix

VadCore: Allow signed multiplication overflow that we don't know how to fix

The right thing to do would be to ensure that the multiplication can't
overflow, but that'd be a major change bordering on a rewrite, and
would take too much time. So instead, we just instruct UBSan to look
the other way.

BUG=chromium:634834
Committed: https://crrev.com/27c7b8ff115205653c84631fb2650f03b7fda33a
Cr-Commit-Position: refs/heads/master@{#14154}

[kwiberg-webrtc, 2016-09-07 12:20:23]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2016-09-07 12:37:50]

Patchset #1 (id:20001) has been deleted

[kwiberg-webrtc, 2016-09-07 12:50:54]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, tina.legrand@webrtc.org

[kwiberg-webrtc, 2016-09-07 12:50:55]

As stated in the bug, I haven't been able to try this fix. But it *should* work.
:-)

[hlundin-webrtc, 2016-09-07 20:35:57]

lgtm

[kwiberg-webrtc, 2016-09-08 08:20:24]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-09-08 08:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-08 08:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 08:24:02]

Try jobs failed on following builders:
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)

[kwiberg-webrtc, 2016-09-08 10:34:39]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2016-09-08 10:34:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2318083002/#ps60001 (title:
"Handle compilers that define __clang__ but don't have the no_sanitize
attribute")

[commit-bot: I haz the power, 2016-09-08 10:34:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-08 11:09:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 11:09:07]

Try jobs failed on following builders:
  android_compile_x86_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_rel...)

[kwiberg-webrtc, 2016-09-08 12:53:55]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-09-08 12:54:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-08 14:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 14:54:43]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kwiberg-webrtc, 2016-09-09 09:02:53]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-09-09 09:03:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-09 09:04:41]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-09-09 09:04:50]

Description was changed from

==========
VadCore: Allow signed multiplication overflow that we don't know how to fix

The right thing to do would be to ensure that the multiplication can't
overflow, but that'd be a major change bordering on a rewrite, and
would take too much time. So instead, we just instruct UBSan to look
the other way.

BUG=chromium:634834
==========

to

==========
VadCore: Allow signed multiplication overflow that we don't know how to fix

The right thing to do would be to ensure that the multiplication can't
overflow, but that'd be a major change bordering on a rewrite, and
would take too much time. So instead, we just instruct UBSan to look
the other way.

BUG=chromium:634834

Committed: https://crrev.com/27c7b8ff115205653c84631fb2650f03b7fda33a
Cr-Commit-Position: refs/heads/master@{#14154}
==========

[commit-bot: I haz the power, 2016-09-09 09:04:51]

Patchset 2 (id:??) landed as
https://crrev.com/27c7b8ff115205653c84631fb2650f03b7fda33a
Cr-Commit-Position: refs/heads/master@{#14154}