Add a chart for packet loss on incoming streams.

Add a chart for packet loss on incoming streams.

Also add stream names to labels.

R=philipel@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/99f8e0841a9d5d49bb3bcccc1e19df56449b4a2d

[stefan-webrtc, 2016-09-08 11:00:14]

stefan@webrtc.org changed reviewers:
+ philipel@webrtc.org

[stefan-webrtc, 2016-09-08 11:00:21]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 11:00:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-08 13:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 13:00:58]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[philipel, 2016-09-08 13:05:53]

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:646: uint16_t expected =
last_in_window->header.sequenceNumber -
|expected| is kind of generic, |expected_num_packets maybe|?

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:646: uint16_t expected =
last_in_window->header.sequenceNumber -
I guess reordering will show up as packet loss, or even as negative packet loss.
Is there some easy way to fix that?

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.h (right):

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.h:70: void
CreateIncomingPacketLossGraph(Plot* plot);
newline between 69-70

[stefan-webrtc, 2016-09-09 07:12:25]

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:646: uint16_t expected =
last_in_window->header.sequenceNumber -
On 2016/09/08 13:05:52, philipel wrote:
> |expected| is kind of generic, |expected_num_packets maybe|?

Done.

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:646: uint16_t expected =
last_in_window->header.sequenceNumber -
On 2016/09/08 13:05:52, philipel wrote:
> I guess reordering will show up as packet loss, or even as negative packet
loss.
> Is there some easy way to fix that?

Reordering around the window boundaries, yes. It becomes a lot more complicated
to try to solve that, so I think we'll just have to keep that in mind. Maybe we
could add a graph for reordered packets instead.

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.h (right):

https://codereview.webrtc.org/2317113003/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.h:70: void
CreateIncomingPacketLossGraph(Plot* plot);
On 2016/09/08 13:05:53, philipel wrote:
> newline between 69-70

Done.

[philipel, 2016-09-09 09:07:54]

lgtm

[stefan-webrtc, 2016-09-09 10:58:58]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-09-09 10:59:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-09 11:38:03]

Description was changed from

==========
Add a chart for packet loss on incoming streams.

Also add stream names to labels.
==========

to

==========
Add a chart for packet loss on incoming streams.

Also add stream names to labels.

R=philipel@webrtc.org

Committed: https://crrev.com/99f8e0841a9d5d49bb3bcccc1e19df56449b4a2d
Cr-Commit-Position: refs/heads/master@{#14159}
==========

[stefan-webrtc, 2016-09-09 11:38:03]

Description was changed from

==========
Add a chart for packet loss on incoming streams.

Also add stream names to labels.
==========

to

==========
Add a chart for packet loss on incoming streams.

Also add stream names to labels.

R=philipel@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/99f8e0841a9d5d49bb3bcccc1...
==========

[commit-bot: I haz the power, 2016-09-09 11:38:04]

Patchset 2 (id:??) landed as
https://crrev.com/99f8e0841a9d5d49bb3bcccc1e19df56449b4a2d
Cr-Commit-Position: refs/heads/master@{#14159}

[stefan-webrtc, 2016-09-09 11:38:04]

Committed patchset #2 (id:20001) manually as
99f8e0841a9d5d49bb3bcccc1e19df56449b4a2d (presubmit successful).