Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2316993002: Only parse PPS up to PPS and SPS ids in the depacketizater. (Closed)

Created:
4 years, 3 months ago by stefan-webrtc
Modified:
4 years, 3 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only parse PPS up to PPS and SPS ids in the depacketizater. BUG= R=danilchap@webrtc.org Committed: https://crrev.com/126ee727a083fd99a2bfcc654062478dcccf3a3a Cr-Commit-Position: refs/heads/master@{#14100}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
M webrtc/common_video/h264/pps_parser.h View 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/common_video/h264/pps_parser.cc View 1 3 chunks +28 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
stefan-webrtc
4 years, 3 months ago (2016-09-07 09:56:34 UTC) #2
danilchap
lgtm https://codereview.webrtc.org/2316993002/diff/1/webrtc/common_video/h264/pps_parser.cc File webrtc/common_video/h264/pps_parser.cc (right): https://codereview.webrtc.org/2316993002/diff/1/webrtc/common_video/h264/pps_parser.cc#newcode31 webrtc/common_video/h264/pps_parser.cc:31: bool PpsParser::ParsePpsIds(const uint8_t* data, Function declaration order should ...
4 years, 3 months ago (2016-09-07 10:38:51 UTC) #7
stefan-webrtc
Comment addressed.
4 years, 3 months ago (2016-09-07 10:44:55 UTC) #8
stefan-webrtc
4 years, 3 months ago (2016-09-07 10:46:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
126ee727a083fd99a2bfcc654062478dcccf3a3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698