Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2316953002: iSAC float: Handle errors in upper band decoding (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/branch-heads/54
Project:
webrtc
Visibility:
Public.

Description

iSAC float: Handle errors in upper band decoding We hit a fuzzer bug that caused numDecodedBytesLB + numDecodedBytesUB > lenEncodedBytes, which is obviously bogus. Check for that, and for the case whhere the UB decoder itself realized that something was wrong. (The code already makes the corresponding check for the LB decoder.) BUG=chromium:637899 (cherry picked from commit d52bef7d6445070532b3c8463859ee4e1f99d70f) Committed: https://chromium.googlesource.com/external/webrtc/+/1605d3a146e894e16975dffaa7c60f7658f2ce97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M webrtc/modules/audio_coding/codecs/isac/main/source/isac.c View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kwiberg-webrtc
Committed patchset #1 (id:1) manually as 1605d3a146e894e16975dffaa7c60f7658f2ce97.
4 years, 3 months ago (2016-09-07 08:15:51 UTC) #2
kwiberg-webrtc
I followed the instructions here [http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-drover.html] to cherry-pick this CL [https://crrev.com/d52bef7d6445070532b3c8463859ee4e1f99d70f] to M54. I was ...
4 years, 3 months ago (2016-09-07 08:21:38 UTC) #4
hlundin-webrtc
4 years, 3 months ago (2016-09-07 11:58:40 UTC) #5
Message was sent while issue was closed.
Drover is trigger-happy. You can give it options to stop at a few intermediate
places.

LGTM

Powered by Google App Engine
This is Rietveld 408576698