Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2316563002: Revert of Remove all reference to carbon api (Closed)

Created:
4 years, 3 months ago by kthelgason
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, sakal
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ ) Reason for revert: Breaks chromium build Original issue's description: > Remove all reference to carbon api > > BUG=webrtc:6282 > > Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964 > Cr-Commit-Position: refs/heads/master@{#14080} TBR=magjed@webrtc.org,mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6282 Committed: https://crrev.com/b096aa7fd375a980daab3a986596548ca5de2a1c Cr-Commit-Position: refs/heads/master@{#14081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+877 lines, -69 lines) Patch
M webrtc/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 4 chunks +8 lines, -1 line 0 comments Download
D webrtc/base/applefilesystem.mm View 1 chunk +0 lines, -53 lines 0 comments Download
M webrtc/base/base.gyp View 4 chunks +19 lines, -1 line 0 comments Download
A webrtc/base/iosfilesystem.mm View 1 chunk +53 lines, -0 lines 0 comments Download
M webrtc/base/macsocketserver.h View 2 chunks +58 lines, -1 line 0 comments Download
M webrtc/base/macsocketserver.cc View 1 chunk +171 lines, -0 lines 0 comments Download
M webrtc/base/macsocketserver_unittest.cc View 2 chunks +74 lines, -0 lines 0 comments Download
M webrtc/base/macutils.h View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/base/macutils.cc View 2 chunks +79 lines, -0 lines 0 comments Download
M webrtc/base/macutils_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M webrtc/base/macwindowpicker.cc View 1 chunk +68 lines, -1 line 0 comments Download
M webrtc/base/proxydetect.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/base/unixfilesystem.cc View 4 chunks +25 lines, -11 lines 0 comments Download
M webrtc/engine_configurations.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
A webrtc/media/devices/carbonvideorenderer.h View 1 chunk +56 lines, -0 lines 0 comments Download
A webrtc/media/devices/carbonvideorenderer.cc View 1 chunk +173 lines, -0 lines 0 comments Download
M webrtc/media/devices/videorendererfactory.h View 2 chunks +12 lines, -0 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/mac/desktop_configuration.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/webrtc_tests.gypi View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kthelgason
Created Revert of Remove all reference to carbon api
4 years, 3 months ago (2016-09-06 07:43:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2316563002/1
4 years, 3 months ago (2016-09-06 07:43:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 07:44:00 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b096aa7fd375a980daab3a986596548ca5de2a1c Cr-Commit-Position: refs/heads/master@{#14081}
4 years, 3 months ago (2016-09-06 07:44:09 UTC) #6
kthelgason
4 years, 3 months ago (2016-09-07 12:02:05 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2321493002/ by kthelgason@webrtc.org.

The reason for reverting is: Chromium build issues have been resolved..

Powered by Google App Engine
This is Rietveld 408576698