Android ThreadUtils: Propagate exceptions in invoke functions

Android ThreadUtils: Propagate exceptions in invoke functions

Right now, RuntimeExceptions thrown in an invoke function will kill the handler thread. This CL propagates the exceptions to the calling thread instead, to give the caller a change to handle them.

BUG=webrtc:6327
Committed: https://crrev.com/7e4b604cda3af5147b391e78abf0639f7094b0d9
Cr-Commit-Position: refs/heads/master@{#14132}

[magjed_webrtc, 2016-09-07 15:56:53]

Description was changed from

==========
Android ThreadUtils: Propagate exceptions in invoke functions

BUG=
==========

to

==========
Android ThreadUtils: Propagate exceptions in invoke functions

Right now, RuntimeExceptions thrown in an invoke function will kill the handler
thread. This CL propagates the exceptions to the calling thread instead, to give
the caller a change to handle them.

BUG=
==========

[magjed_webrtc, 2016-09-07 15:56:53]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2016-09-07 15:57:03]

Sami - please take a look.

[sakal, 2016-09-08 08:13:19]

lgtm

https://codereview.webrtc.org/2316223002/diff/1/webrtc/base/java/src/org/webr...
File webrtc/base/java/src/org/webrtc/ThreadUtils.java (right):

https://codereview.webrtc.org/2316223002/diff/1/webrtc/base/java/src/org/webr...
webrtc/base/java/src/org/webrtc/ThreadUtils.java:206: private static
StackTraceElement[] concat(StackTraceElement[] inner, StackTraceElement[] outer)
{
nit: Maybe name it concatStackTraces instead?

[magjed_webrtc, 2016-09-08 09:34:49]

Description was changed from

==========
Android ThreadUtils: Propagate exceptions in invoke functions

Right now, RuntimeExceptions thrown in an invoke function will kill the handler
thread. This CL propagates the exceptions to the calling thread instead, to give
the caller a change to handle them.

BUG=
==========

to

==========
Android ThreadUtils: Propagate exceptions in invoke functions

Right now, RuntimeExceptions thrown in an invoke function will kill the handler
thread. This CL propagates the exceptions to the calling thread instead, to give
the caller a change to handle them.

BUG=webrtc:6327
==========

[magjed_webrtc, 2016-09-08 09:35:32]

https://codereview.webrtc.org/2316223002/diff/1/webrtc/base/java/src/org/webr...
File webrtc/base/java/src/org/webrtc/ThreadUtils.java (right):

https://codereview.webrtc.org/2316223002/diff/1/webrtc/base/java/src/org/webr...
webrtc/base/java/src/org/webrtc/ThreadUtils.java:206: private static
StackTraceElement[] concat(StackTraceElement[] inner, StackTraceElement[] outer)
{
On 2016/09/08 08:13:18, sakal wrote:
> nit: Maybe name it concatStackTraces instead?

Done.

[magjed_webrtc, 2016-09-08 09:35:38]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-09-08 09:35:38]

The patchset sent to the CQ was uploaded after l-g-t-m from sakal@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2316223002/#ps20001 (title:
"Rename to concatStackTraces")

[commit-bot: I haz the power, 2016-09-08 09:35:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-08 12:06:34]

Description was changed from

==========
Android ThreadUtils: Propagate exceptions in invoke functions

Right now, RuntimeExceptions thrown in an invoke function will kill the handler
thread. This CL propagates the exceptions to the calling thread instead, to give
the caller a change to handle them.

BUG=webrtc:6327
==========

to

==========
Android ThreadUtils: Propagate exceptions in invoke functions

Right now, RuntimeExceptions thrown in an invoke function will kill the handler
thread. This CL propagates the exceptions to the calling thread instead, to give
the caller a change to handle them.

BUG=webrtc:6327
==========

[commit-bot: I haz the power, 2016-09-08 12:06:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 12:06:39]

Description was changed from

==========
Android ThreadUtils: Propagate exceptions in invoke functions

Right now, RuntimeExceptions thrown in an invoke function will kill the handler
thread. This CL propagates the exceptions to the calling thread instead, to give
the caller a change to handle them.

BUG=webrtc:6327
==========

to

==========
Android ThreadUtils: Propagate exceptions in invoke functions

Right now, RuntimeExceptions thrown in an invoke function will kill the handler
thread. This CL propagates the exceptions to the calling thread instead, to give
the caller a change to handle them.

BUG=webrtc:6327

Committed: https://crrev.com/7e4b604cda3af5147b391e78abf0639f7094b0d9
Cr-Commit-Position: refs/heads/master@{#14132}
==========

[commit-bot: I haz the power, 2016-09-08 12:06:40]

Patchset 2 (id:??) landed as
https://crrev.com/7e4b604cda3af5147b391e78abf0639f7094b0d9
Cr-Commit-Position: refs/heads/master@{#14132}