Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2315693002: iSAC float: Handle errors in upper band decoding (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iSAC float: Handle errors in upper band decoding We hit a fuzzer bug that caused numDecodedBytesLB + numDecodedBytesUB > lenEncodedBytes, which is obviously bogus. Check for that, and for the case whhere the UB decoder itself realized that something was wrong. (The code already makes the corresponding check for the LB decoder.) BUG=chromium:637899 Committed: https://crrev.com/d52bef7d6445070532b3c8463859ee4e1f99d70f Cr-Commit-Position: refs/heads/master@{#14091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M webrtc/modules/audio_coding/codecs/isac/main/source/isac.c View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-09-06 12:00:57 UTC) #2
hlundin-webrtc
lgtm
4 years, 3 months ago (2016-09-06 13:02:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2315693002/1
4 years, 3 months ago (2016-09-06 13:08:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 13:16:06 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 13:16:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d52bef7d6445070532b3c8463859ee4e1f99d70f
Cr-Commit-Position: refs/heads/master@{#14091}

Powered by Google App Engine
This is Rietveld 408576698