Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: webrtc/media/base/videoframe.h

Issue 2315663002: Make cricket::VideoFrame inherit webrtc::VideoFrame. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MEDIA_BASE_VIDEOFRAME_H_ 11 #ifndef WEBRTC_MEDIA_BASE_VIDEOFRAME_H_
12 #define WEBRTC_MEDIA_BASE_VIDEOFRAME_H_ 12 #define WEBRTC_MEDIA_BASE_VIDEOFRAME_H_
13 13
14 #include "webrtc/video_frame.h"
15
16 #if 0
14 #include "webrtc/base/basictypes.h" 17 #include "webrtc/base/basictypes.h"
15 #include "webrtc/base/stream.h" 18 #include "webrtc/base/stream.h"
16 #include "webrtc/common_video/include/video_frame_buffer.h" 19 #include "webrtc/common_video/include/video_frame_buffer.h"
17 #include "webrtc/common_video/rotation.h" 20 #include "webrtc/common_video/rotation.h"
21 #endif
18 22
19 namespace cricket { 23 namespace cricket {
20 24
25 using VideoFrame = webrtc::VideoFrame;
26 #if 0
21 // Represents a YUV420 (a.k.a. I420) video frame. 27 // Represents a YUV420 (a.k.a. I420) video frame.
22 28
23 // TODO(nisse): This class duplicates webrtc::VideoFrame. There's 29 // TODO(nisse): This class duplicates webrtc::VideoFrame. There's
24 // ongoing work to merge the classes. See 30 // ongoing work to merge the classes. See
25 // https://bugs.chromium.org/p/webrtc/issues/detail?id=5682. 31 // https://bugs.chromium.org/p/webrtc/issues/detail?id=5682.
26 class VideoFrame { 32 class VideoFrame {
27 public: 33 public:
28 VideoFrame() {} 34 VideoFrame() {}
29 virtual ~VideoFrame() {} 35 virtual ~VideoFrame() {}
30 36
(...skipping 29 matching lines...) Expand all
60 // TODO(nisse): Deprecated. Should be deleted in the cricket::VideoFrame and 66 // TODO(nisse): Deprecated. Should be deleted in the cricket::VideoFrame and
61 // webrtc::VideoFrame merge. Validation of sample_size possibly moved to 67 // webrtc::VideoFrame merge. Validation of sample_size possibly moved to
62 // libyuv::ConvertToI420. As an initial step, demote this method to protected 68 // libyuv::ConvertToI420. As an initial step, demote this method to protected
63 // status. Used only by WebRtcVideoFrame::Reset. 69 // status. Used only by WebRtcVideoFrame::Reset.
64 static bool Validate(uint32_t fourcc, 70 static bool Validate(uint32_t fourcc,
65 int w, 71 int w,
66 int h, 72 int h,
67 const uint8_t* sample, 73 const uint8_t* sample,
68 size_t sample_size); 74 size_t sample_size);
69 }; 75 };
76 #endif
70 77
71 } // namespace cricket 78 } // namespace cricket
72 79
73 #endif // WEBRTC_MEDIA_BASE_VIDEOFRAME_H_ 80 #endif // WEBRTC_MEDIA_BASE_VIDEOFRAME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698