Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2315363004: Avoids crash in WebRtcAudioTrack.initPlayout (Closed)

Created:
4 years, 3 months ago by henrika_webrtc
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Avoids crash in WebRtcAudioTrack.initPlayout BUG=NONE R=magjed@webrtc.org Committed: https://crrev.com/2c993ce5053fae1251770a89a7550a40d9dc4442 Cr-Commit-Position: refs/heads/master@{#14129}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java View 1 chunk +14 lines, -4 lines 3 comments Download

Messages

Total messages: 9 (4 generated)
henrika_webrtc
PTAL
4 years, 3 months ago (2016-09-08 09:42:24 UTC) #3
magjed_webrtc
lgtm https://codereview.webrtc.org/2315363004/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java (right): https://codereview.webrtc.org/2315363004/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java#newcode193 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:193: Logging.e(TAG, "AudioTrack.getMinBufferSize returns an invalid value."); nit: Maybe ...
4 years, 3 months ago (2016-09-08 09:45:21 UTC) #4
henrika_webrtc
https://codereview.webrtc.org/2315363004/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java (right): https://codereview.webrtc.org/2315363004/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java#newcode193 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:193: Logging.e(TAG, "AudioTrack.getMinBufferSize returns an invalid value."); But is is ...
4 years, 3 months ago (2016-09-08 09:46:52 UTC) #5
magjed_webrtc
https://codereview.webrtc.org/2315363004/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java (right): https://codereview.webrtc.org/2315363004/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java#newcode193 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:193: Logging.e(TAG, "AudioTrack.getMinBufferSize returns an invalid value."); On 2016/09/08 09:46:52, ...
4 years, 3 months ago (2016-09-08 09:48:18 UTC) #6
henrika_webrtc
4 years, 3 months ago (2016-09-08 11:36:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2c993ce5053fae1251770a89a7550a40d9dc4442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698