webrtc/common_audio/signal_processing/include/signal_processing_library.h - Issue 2314413002: iSAC fix: Ignore overflow in signed left shift

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/signal_processing/include/signal_processing_library.h

Issue 2314413002: iSAC fix: Ignore overflow in signed left shift (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/common_audio/signal_processing/include/signal_processing_library.h

diff --git a/webrtc/common_audio/signal_processing/include/signal_processing_library.h b/webrtc/common_audio/signal_processing/include/signal_processing_library.h

index 3a60c1db8e0f57840a7e041424d83cfac941a83d..89a281f41033c1d5bfeba93afd1b1b313b1535a1 100644

--- a/webrtc/common_audio/signal_processing/include/signal_processing_library.h

+++ b/webrtc/common_audio/signal_processing/include/signal_processing_library.h

@@ -63,9 +63,9 @@

#define WEBRTC_SPL_MUL_16_32_RSFT14(a, b) \

(WEBRTC_SPL_MUL_16_16(a, (b) >> 16) * (1 << 2) + \

(((WEBRTC_SPL_MUL_16_U16(a, (uint16_t)(b)) >> 1) + 0x1000) >> 13))

-#define WEBRTC_SPL_MUL_16_32_RSFT15(a, b) \

- ((WEBRTC_SPL_MUL_16_16(a, (b) >> 16) << 1) \

- + (((WEBRTC_SPL_MUL_16_U16(a, (uint16_t)(b)) >> 1) + 0x2000) >> 14))

+#define WEBRTC_SPL_MUL_16_32_RSFT15(a, b) \

+ ((WEBRTC_SPL_MUL_16_16(a, (b) >> 16) * (1 << 1)) + \

+ (((WEBRTC_SPL_MUL_16_U16(a, (uint16_t)(b)) >> 1) + 0x2000) >> 14))

#define WEBRTC_SPL_MUL_16_16_RSFT(a, b, c) \

(WEBRTC_SPL_MUL_16_16(a, b) >> (c))

« no previous file with comments | « no previous file | webrtc/modules/audio_coding/codecs/isac/fix/source/lattice.c » ('j') | no next file with comments »