Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: webrtc/video/video_quality_test.h

Issue 2314403007: Reland of "Separating video settings in VideoQualityTest". (Closed)
Patch Set: Adding initialization. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/video_quality_test.h
diff --git a/webrtc/video/video_quality_test.h b/webrtc/video/video_quality_test.h
index e5c85aa2312f58ce0e5b90c9109bbe2a51b75f7a..4fb862415126ba66f937d2b5888a1b9be883e99b 100644
--- a/webrtc/video/video_quality_test.h
+++ b/webrtc/video/video_quality_test.h
@@ -27,7 +27,14 @@ class VideoQualityTest : public test::CallTest {
// Unfortunately, C++11 (as opposed to C11) doesn't support unnamed structs,
// which makes the implementation of VideoQualityTest a bit uglier.
struct Params {
+ Params();
+ ~Params();
struct {
+ bool send_side_bwe;
+ Call::Config::BitrateConfig call_bitrate_config;
+ } call;
+ struct {
+ bool enabled;
size_t width;
size_t height;
int32_t fps;
@@ -39,20 +46,19 @@ class VideoQualityTest : public test::CallTest {
int num_temporal_layers;
int selected_tl;
int min_transmit_bps;
- bool send_side_bwe;
bool fec;
-
- Call::Config::BitrateConfig call_bitrate_config;
- } common;
- struct { // Video-specific settings.
std::string clip_name;
} video;
- struct { // Screenshare-specific settings.
+ struct {
+ bool enabled;
+ bool sync_video;
+ } audio;
+ struct {
bool enabled;
int32_t slide_change_interval;
int32_t scroll_duration;
} screenshare;
- struct { // Analyzer settings.
+ struct {
std::string test_label;
double avg_psnr_threshold; // (*)
double avg_ssim_threshold; // (*)
@@ -70,8 +76,6 @@ class VideoQualityTest : public test::CallTest {
// If empty, bitrates are generated in VP9Impl automatically.
std::vector<SpatialLayer> spatial_layers;
} ss;
- bool audio;
- bool audio_video_sync;
};
// (*) Set to -1.1 if generating graph data for simulcast or SVC and the
// selected stream/layer doesn't have the same resolution as the largest

Powered by Google App Engine
This is Rietveld 408576698