Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2313913002: GN: Set WEBRTC_RESTRICT_LOGGING as is set in GYP. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Set WEBRTC_RESTRICT_LOGGING as is set in GYP. In GYP the define is set when we build with chrome, but it's always set in GN. NOTRY=True BUG=webrtc:6312 Committed: https://crrev.com/edaa4a45ef6cb516c3c205cc001650408542e367 Cr-Commit-Position: refs/heads/master@{#14086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/build/webrtc.gni View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-06 08:57:55 UTC) #3
kjellander_webrtc
lgtm You don't necessarily need to file a bug for a small change like this, ...
4 years, 3 months ago (2016-09-06 09:16:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2313913002/20001
4 years, 3 months ago (2016-09-06 09:18:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-06 09:27:49 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 09:27:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edaa4a45ef6cb516c3c205cc001650408542e367
Cr-Commit-Position: refs/heads/master@{#14086}

Powered by Google App Engine
This is Rietveld 408576698