Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2313473002:
Copy RTCAudioSource.h and RTCMediaSource.h with other public header files when building the WebRTC … (Closed)
|
Created:
4 years, 3 months ago by VladimirTechMan Modified:
4 years, 3 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionCopy RTCAudioSource.h and RTCMediaSource.h with other public header files when building the WebRTC framework for iOS / Mac
NOTRY=True
Committed: https://crrev.com/a264ecc45665da5a76467cbf8a422bd83a89fb85
Cr-Commit-Position: refs/heads/master@{#14117}
Patch Set 1 #Messages
Total messages: 18 (6 generated)
vladimirtechman@gmail.com changed reviewers: + kjellander@webrtc.org, tkchin@webrtc.org
Issue: The RTCAudioSource.h and RTCMediaSource.h files, which were recently added to the WebRTC SDK for iOS / Mac, are not copied to the directory with public files after building the framework (based on the rules in webrtc/sdk/sdk.gyp). As the files are actually referenced in WebRTC.h and VideoSource.h, it makes the XCode projects using the framework fail while building. Fix: Add the file names to the related part of rules in sdk.gyp. Workaround, if any: A workaround before this fix is committed is to copy the two files manually.)
vladimirtechman@gmail.com changed reviewers: + tommi@webrtc.org
Description was changed from ========== Copy RTCAudioSource.h and RTCMediaSource.h with other public header files when building the WebRTC framework for iOS / Mac BUG= ========== to ========== Copy RTCAudioSource.h and RTCMediaSource.h with other public header files when building the WebRTC framework for iOS / Mac NOTRY=True ==========
lgtm Zeke: have you any plan for a GN version of this target yet? Is it blocked on anything?
lgtm
On 2016/09/05 05:58:31, kjellander_webrtc wrote: > lgtm > > Zeke: have you any plan for a GN version of this target yet? Is it blocked on > anything? Okay, let's wait when Zeke is back and can get to my request.
On 2016/09/07 03:32:10, VladimirTechMan wrote: > On 2016/09/05 05:58:31, kjellander_webrtc wrote: > > lgtm > > > > Zeke: have you any plan for a GN version of this target yet? Is it blocked on > > anything? > > Okay, let's wait when Zeke is back and can get to my request. It's fine to submit this now, no need to wait for Zeke. I'm actually going to start looking at creating such a target today, since it's blocking us from getting rid of GYP.
On 2016/09/07 05:12:11, kjellander_webrtc wrote: > On 2016/09/07 03:32:10, VladimirTechMan wrote: > > On 2016/09/05 05:58:31, kjellander_webrtc wrote: > > > lgtm > > > > > > Zeke: have you any plan for a GN version of this target yet? Is it blocked > on > > > anything? > > > > Okay, let's wait when Zeke is back and can get to my request. > > It's fine to submit this now, no need to wait for Zeke. > I'm actually going to start looking at creating such a target today, since it's > blocking us from getting rid of GYP. Thanks, Henrik. I like the plan!
On 2016/09/07 05:44:43, VladimirTechMan wrote: > On 2016/09/07 05:12:11, kjellander_webrtc wrote: > > On 2016/09/07 03:32:10, VladimirTechMan wrote: > > > On 2016/09/05 05:58:31, kjellander_webrtc wrote: > > > > lgtm > > > > > > > > Zeke: have you any plan for a GN version of this target yet? Is it blocked > > on > > > > anything? > > > > > > Okay, let's wait when Zeke is back and can get to my request. > > > > It's fine to submit this now, no need to wait for Zeke. > > I'm actually going to start looking at creating such a target today, since > it's > > blocking us from getting rid of GYP. > > Thanks, Henrik. I like the plan! In any case, let me know if any further actions are required from my side. (As I cannot directly commit myself at this stage, that will need to be one of you, folks.)
On 2016/09/07 23:34:33, VladimirTechMan wrote: > On 2016/09/07 05:44:43, VladimirTechMan wrote: > > On 2016/09/07 05:12:11, kjellander_webrtc wrote: > > > On 2016/09/07 03:32:10, VladimirTechMan wrote: > > > > On 2016/09/05 05:58:31, kjellander_webrtc wrote: > > > > > lgtm > > > > > > > > > > Zeke: have you any plan for a GN version of this target yet? Is it > blocked > > > on > > > > > anything? > > > > > > > > Okay, let's wait when Zeke is back and can get to my request. > > > > > > It's fine to submit this now, no need to wait for Zeke. > > > I'm actually going to start looking at creating such a target today, since > > it's > > > blocking us from getting rid of GYP. > > > > Thanks, Henrik. I like the plan! > > In any case, let me know if any further actions are required from my side. (As I > cannot directly commit myself at this stage, that will need to be one of you, > folks.) This is fine. And you should be able to land using the Commit queue (check the Commit checkbox) once you got LGTM from OWNERS. I can do it for you though.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Copy RTCAudioSource.h and RTCMediaSource.h with other public header files when building the WebRTC framework for iOS / Mac NOTRY=True ========== to ========== Copy RTCAudioSource.h and RTCMediaSource.h with other public header files when building the WebRTC framework for iOS / Mac NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Copy RTCAudioSource.h and RTCMediaSource.h with other public header files when building the WebRTC framework for iOS / Mac NOTRY=True ========== to ========== Copy RTCAudioSource.h and RTCMediaSource.h with other public header files when building the WebRTC framework for iOS / Mac NOTRY=True Committed: https://crrev.com/a264ecc45665da5a76467cbf8a422bd83a89fb85 Cr-Commit-Position: refs/heads/master@{#14117} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a264ecc45665da5a76467cbf8a422bd83a89fb85 Cr-Commit-Position: refs/heads/master@{#14117} |
