Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2312853002: Remove dedicated unittest file for remb format (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dedicated unittest file for remb format RembStatus moved to RtcpSender unittest where it fits better Creating remb in Compound/ReducedSize modes already covered by RtcpSender unittests. Parsing remb already covered by RtcpReceiverTest.ReceivesRemb R=stefan@webrtc.org Committed: https://crrev.com/857a8fb861d6c8423372f9dc271d52ecbea384f3 Cr-Commit-Position: refs/heads/master@{#14088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -141 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
danilchap
4 years, 3 months ago (2016-09-06 08:25:50 UTC) #3
stefan-webrtc
lgtm
4 years, 3 months ago (2016-09-06 09:12:26 UTC) #4
danilchap
4 years, 3 months ago (2016-09-06 09:41:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
857a8fb861d6c8423372f9dc271d52ecbea384f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698