Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: webrtc/video/screenshare_loopback.cc

Issue 2312613003: Separating video settings in VideoQualityTest. (Closed)
Patch Set: on Stefan's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/full_stack.cc ('k') | webrtc/video/video_loopback.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/screenshare_loopback.cc
diff --git a/webrtc/video/screenshare_loopback.cc b/webrtc/video/screenshare_loopback.cc
index 82e51dd9398ef75595a0008f59745a7d2b16419a..fb49463e8d026bac132eb929f3cee3013baa933e 100644
--- a/webrtc/video/screenshare_loopback.cc
+++ b/webrtc/video/screenshare_loopback.cc
@@ -224,20 +224,28 @@ void Loopback() {
call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000;
VideoQualityTest::Params params;
- params.common = {flags::Width(), flags::Height(), flags::Fps(),
- flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000,
- flags::MaxBitrateKbps() * 1000, false, flags::Codec(),
- flags::NumTemporalLayers(), flags::SelectedTL(),
- flags::MinTransmitBitrateKbps() * 1000, flags::FLAGS_send_side_bwe,
- false, call_bitrate_config};
+ params.call = {flags::FLAGS_send_side_bwe, call_bitrate_config};
+ params.video = {true,
+ flags::Width(),
+ flags::Height(),
+ flags::Fps(),
+ flags::MinBitrateKbps() * 1000,
+ flags::TargetBitrateKbps() * 1000,
+ flags::MaxBitrateKbps() * 1000,
+ false,
+ flags::Codec(),
+ flags::NumTemporalLayers(),
+ flags::SelectedTL(),
+ flags::MinTransmitBitrateKbps() * 1000,
+ false,
+ ""};
+ params.audio = {false, false};
params.screenshare = {true, flags::SlideChangeInterval(),
flags::ScrollDuration()};
params.analyzer = {"screenshare", 0.0, 0.0, flags::DurationSecs(),
flags::OutputFilename(), flags::GraphTitle()};
params.pipe = pipe_config;
params.logs = flags::FLAGS_logs;
- params.audio = false;
- params.audio_video_sync = false;
std::vector<std::string> stream_descriptors;
stream_descriptors.push_back(flags::Stream0());
« no previous file with comments | « webrtc/video/full_stack.cc ('k') | webrtc/video/video_loopback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698