Separating video settings in VideoQualityTest.

webrtc/video/video_quality_test.h

Index: webrtc/video/video_quality_test.h
diff --git a/webrtc/video/video_quality_test.h b/webrtc/video/video_quality_test.h
index e5c85aa2312f58ce0e5b90c9109bbe2a51b75f7a..3dd53e4837c14a8f9190ec8f161b4bdd213ebfb6 100644
--- a/webrtc/video/video_quality_test.h
+++ b/webrtc/video/video_quality_test.h
@@ -28,6 +28,11 @@ class VideoQualityTest : public test::CallTest {
   // which makes the implementation of VideoQualityTest a bit uglier.
   struct Params {
     struct {
+      bool send_side_bwe;
+      Call::Config::BitrateConfig call_bitrate_config;
+    } common;

[stefan-webrtc, 2016/09/07 13:33:32]

I think common should either be called "call" or "bwe" to match the code
structure.

[minyue-webrtc, 2016/09/08 09:38:40]

Done.

+    struct {  // Video-specific settings.

[stefan-webrtc, 2016/09/07 13:33:32]

Remove comment, I think we're fine without it.

[minyue-webrtc, 2016/09/08 09:38:40]

Done.

+      bool enabled;
       size_t width;
       size_t height;
       int32_t fps;
@@ -39,14 +44,13 @@ class VideoQualityTest : public test::CallTest {
       int num_temporal_layers;
       int selected_tl;
       int min_transmit_bps;
-      bool send_side_bwe;
       bool fec;
-
-      Call::Config::BitrateConfig call_bitrate_config;
-    } common;
-    struct {  // Video-specific settings.
       std::string clip_name;
     } video;
+    struct {  // Audio-specific

[stefan-webrtc, 2016/09/07 13:33:32]

This comment isn't needed.

[minyue-webrtc, 2016/09/08 09:38:40]

Done.

+      bool enabled;
+      bool sync_video;
+    } audio;
     struct {  // Screenshare-specific settings.
       bool enabled;
       int32_t slide_change_interval;
@@ -70,8 +74,6 @@ class VideoQualityTest : public test::CallTest {
       // If empty, bitrates are generated in VP9Impl automatically.
       std::vector<SpatialLayer> spatial_layers;
     } ss;
-    bool audio;
-    bool audio_video_sync;
   };
   // (*) Set to -1.1 if generating graph data for simulcast or SVC and the
   // selected stream/layer doesn't have the same resolution as the largest