Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: webrtc/video/video_loopback.cc

Issue 2312613003: Separating video settings in VideoQualityTest. (Closed)
Patch Set: on Stefan's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/screenshare_loopback.cc ('k') | webrtc/video/video_quality_test.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 pipe_config.queue_delay_ms = flags::AvgPropagationDelayMs(); 223 pipe_config.queue_delay_ms = flags::AvgPropagationDelayMs();
224 pipe_config.delay_standard_deviation_ms = flags::StdPropagationDelayMs(); 224 pipe_config.delay_standard_deviation_ms = flags::StdPropagationDelayMs();
225 pipe_config.allow_reordering = flags::FLAGS_allow_reordering; 225 pipe_config.allow_reordering = flags::FLAGS_allow_reordering;
226 226
227 Call::Config::BitrateConfig call_bitrate_config; 227 Call::Config::BitrateConfig call_bitrate_config;
228 call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000; 228 call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000;
229 call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000; 229 call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000;
230 call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000; 230 call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000;
231 231
232 VideoQualityTest::Params params; 232 VideoQualityTest::Params params;
233 params.common = {flags::Width(), flags::Height(), flags::Fps(), 233 params.call = {flags::FLAGS_send_side_bwe, call_bitrate_config};
234 flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000, 234 params.video = {true,
235 flags::MaxBitrateKbps() * 1000, flags::FLAGS_suspend_below_min_bitrate, 235 flags::Width(),
236 flags::Codec(), flags::NumTemporalLayers(), flags::SelectedTL(), 236 flags::Height(),
237 0, // No min transmit bitrate. 237 flags::Fps(),
238 flags::FLAGS_send_side_bwe, flags::FLAGS_use_fec, call_bitrate_config}; 238 flags::MinBitrateKbps() * 1000,
239 params.video = {flags::Clip()}; 239 flags::TargetBitrateKbps() * 1000,
240 flags::MaxBitrateKbps() * 1000,
241 flags::FLAGS_suspend_below_min_bitrate,
242 flags::Codec(),
243 flags::NumTemporalLayers(),
244 flags::SelectedTL(),
245 0, // No min transmit bitrate.
246 flags::FLAGS_use_fec,
247 flags::Clip()};
248 params.audio = {flags::FLAGS_audio, flags::FLAGS_audio_video_sync};
240 params.analyzer = {"video", 0.0, 0.0, flags::DurationSecs(), 249 params.analyzer = {"video", 0.0, 0.0, flags::DurationSecs(),
241 flags::OutputFilename(), flags::GraphTitle()}; 250 flags::OutputFilename(), flags::GraphTitle()};
242 params.pipe = pipe_config; 251 params.pipe = pipe_config;
243 params.logs = flags::FLAGS_logs; 252 params.logs = flags::FLAGS_logs;
244 params.audio = flags::FLAGS_audio,
245 params.audio_video_sync = flags::FLAGS_audio_video_sync;
246 253
247 std::vector<std::string> stream_descriptors; 254 std::vector<std::string> stream_descriptors;
248 stream_descriptors.push_back(flags::Stream0()); 255 stream_descriptors.push_back(flags::Stream0());
249 stream_descriptors.push_back(flags::Stream1()); 256 stream_descriptors.push_back(flags::Stream1());
250 std::vector<std::string> SL_descriptors; 257 std::vector<std::string> SL_descriptors;
251 SL_descriptors.push_back(flags::SL0()); 258 SL_descriptors.push_back(flags::SL0());
252 SL_descriptors.push_back(flags::SL1()); 259 SL_descriptors.push_back(flags::SL1());
253 VideoQualityTest::FillScalabilitySettings( 260 VideoQualityTest::FillScalabilitySettings(
254 &params, stream_descriptors, flags::SelectedStream(), 261 &params, stream_descriptors, flags::SelectedStream(),
255 flags::NumSpatialLayers(), flags::SelectedSL(), SL_descriptors); 262 flags::NumSpatialLayers(), flags::SelectedSL(), SL_descriptors);
256 263
257 VideoQualityTest test; 264 VideoQualityTest test;
258 if (flags::DurationSecs()) { 265 if (flags::DurationSecs()) {
259 test.RunWithAnalyzer(params); 266 test.RunWithAnalyzer(params);
260 } else { 267 } else {
261 test.RunWithRenderers(params); 268 test.RunWithRenderers(params);
262 } 269 }
263 } 270 }
264 } // namespace webrtc 271 } // namespace webrtc
265 272
266 int main(int argc, char* argv[]) { 273 int main(int argc, char* argv[]) {
267 ::testing::InitGoogleTest(&argc, argv); 274 ::testing::InitGoogleTest(&argc, argv);
268 google::ParseCommandLineFlags(&argc, &argv, true); 275 google::ParseCommandLineFlags(&argc, &argv, true);
269 webrtc::test::InitFieldTrialsFromString( 276 webrtc::test::InitFieldTrialsFromString(
270 webrtc::flags::FLAGS_force_fieldtrials); 277 webrtc::flags::FLAGS_force_fieldtrials);
271 webrtc::test::RunTest(webrtc::Loopback); 278 webrtc::test::RunTest(webrtc::Loopback);
272 return 0; 279 return 0;
273 } 280 }
OLDNEW
« no previous file with comments | « webrtc/video/screenshare_loopback.cc ('k') | webrtc/video/video_quality_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698