Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 2312143002: Merge min_ms and max_ms accessors in PlayoutDelayOracle (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/playout_delay_oracle_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
index fc677d77601c0785fc3a55aa25d3900c464463f7..9622f8b82653837f746df858dcc237f06223de5c 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
@@ -481,8 +481,9 @@ bool RTPSender::SendOutgoingData(FrameType frame_type,
// on what the oracle indicates.
{
rtc::CritScope lock(&send_critsect_);
- if (playout_delay_active_ != playout_delay_oracle_.send_playout_delay()) {
- playout_delay_active_ = playout_delay_oracle_.send_playout_delay();
+ bool send_playout_delay = playout_delay_oracle_.send_playout_delay();
+ if (playout_delay_active_ != send_playout_delay) {
+ playout_delay_active_ = send_playout_delay;
rtp_header_extension_map_.SetActive(kRtpExtensionPlayoutDelay,
playout_delay_active_);
}
@@ -1177,11 +1178,12 @@ uint16_t RTPSender::BuildRtpHeaderExtension(uint8_t* data_buffer,
block_length = BuildTransportSequenceNumberExtension(
extension_data, transport_sequence_number_);
break;
- case kRtpExtensionPlayoutDelay:
+ case kRtpExtensionPlayoutDelay: {
+ PlayoutDelay playout_delay = playout_delay_oracle_.playout_delay();
block_length = BuildPlayoutDelayExtension(
- extension_data, playout_delay_oracle_.min_playout_delay_ms(),
- playout_delay_oracle_.max_playout_delay_ms());
+ extension_data, playout_delay.min_ms, playout_delay.max_ms);
break;
+ }
default:
assert(false);
}
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/playout_delay_oracle_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698