Issue 2312143002: Merge min_ms and max_ms accessors in PlayoutDelayOracle

Issue 2312143002: Merge min_ms and max_ms accessors in PlayoutDelayOracle (Closed)

Created:
4 years, 3 months ago by danilchap

Modified:
4 years, 3 months ago

Reviewers:
Irfan

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Merge min_ms and max_ms accessors in PlayoutDelayOracle to reduce CriticalSection enterencies and avoid potentional synchronisation issues. R=isheriff@chromium.org Committed: https://crrev.com/9881cb28747d966072e1fa61f79eee4d0ca7cb64 Cr-Commit-Position: refs/heads/master@{#14101}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -28 lines)			Patch
M	webrtc/modules/rtp_rtcp/source/playout_delay_oracle.h	View	2 chunks	+5 lines, -13 lines	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/playout_delay_oracle.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/playout_delay_oracle_unittest.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtp_sender.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download

Total messages: 6 (3 generated)

danilchap

Also I need it to simplify using it with PlayoutDelayLimits (extension trait introduced in a ...

4 years, 3 months ago (2016-09-06 13:28:27 UTC) #2

danilchap

4 years, 3 months ago (2016-09-07 11:30:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9881cb28747d966072e1fa61f79eee4d0ca7cb64 (presubmit successful).