Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: webrtc/modules/video_coding/BUILD.gn

Issue 2311843002: GN Templates: Move common_inherited_config to the template. (Closed)
Patch Set: Added comment for rtc_common_inherited_config. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_capture/BUILD.gn ('k') | webrtc/modules/video_processing/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/BUILD.gn
diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn
index 1b684d883fc9147c8c43df898953f8577e792b19..4f3b8e50f06179b090b205276385878ea7f23d04 100644
--- a/webrtc/modules/video_coding/BUILD.gn
+++ b/webrtc/modules/video_coding/BUILD.gn
@@ -74,8 +74,6 @@ rtc_source_set("video_coding") {
"video_sender.cc",
]
- public_configs = [ "../..:common_inherited_config" ]
-
# TODO(jschuh): Bug 1348: fix this warning.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
@@ -114,8 +112,6 @@ rtc_source_set("video_coding_utility") {
"utility/vp8_header_parser.h",
]
- public_configs = [ "../..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -134,8 +130,6 @@ rtc_source_set("webrtc_h264") {
"codecs/h264/include/h264.h",
]
- public_configs = [ "../..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -227,8 +221,6 @@ rtc_source_set("webrtc_i420") {
"codecs/i420/include/i420.h",
]
- public_configs = [ "../..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -258,8 +250,6 @@ rtc_source_set("webrtc_vp8") {
"codecs/vp8/vp8_impl.h",
]
- public_configs = [ "../..:common_inherited_config" ]
-
# TODO(jschuh): Bug 1348: fix this warning.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
@@ -291,8 +281,6 @@ rtc_source_set("webrtc_vp9") {
"codecs/vp9/vp9_impl.h",
]
- public_configs = [ "../..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -324,8 +312,6 @@ if (rtc_include_tests) {
"codecs/test/videoprocessor.h",
]
- public_configs = [ "../..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
« no previous file with comments | « webrtc/modules/video_capture/BUILD.gn ('k') | webrtc/modules/video_processing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698