Chromium Code Reviews

Unified Diff: webrtc/common_audio/BUILD.gn

Issue 2311843002: GN Templates: Move common_inherited_config to the template. (Closed)
Patch Set: Added comment for rtc_common_inherited_config. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « webrtc/call/BUILD.gn ('k') | webrtc/common_video/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_audio/BUILD.gn
diff --git a/webrtc/common_audio/BUILD.gn b/webrtc/common_audio/BUILD.gn
index 195e9718c7d07a773f8868795720f95911d6cde8..08a97b2507ffa5690145c30ecc202ddb48d3ec23 100644
--- a/webrtc/common_audio/BUILD.gn
+++ b/webrtc/common_audio/BUILD.gn
@@ -172,10 +172,7 @@ rtc_source_set("common_audio") {
cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion.
}
- public_configs = [
- "..:common_inherited_config",
- ":common_audio_config",
- ]
+ public_configs = [ ":common_audio_config" ]
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
@@ -199,8 +196,6 @@ if (current_cpu == "x86" || current_cpu == "x64") {
cflags = [ "-msse2" ]
}
- configs += [ "..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -236,8 +231,6 @@ if (rtc_build_with_neon) {
]
}
- public_configs = [ "..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -284,8 +277,6 @@ if (rtc_include_tests) {
sources += [ "resampler/sinc_resampler_unittest.cc" ]
}
- public_configs = [ "..:common_inherited_config" ]
-
if (rtc_use_openmax_dl) {
defines = [ "RTC_USE_OPENMAX_DL" ]
}
« no previous file with comments | « webrtc/call/BUILD.gn ('k') | webrtc/common_video/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine