Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2310983002: Enable gyp_compare_flag_script to compare all targets. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable gyp_compare_flag_script to compare all targets. BUG=webrtc:6310 NOTRY=True Committed: https://crrev.com/0b1b472c511172a8189e7f81a1aec07ac35a2e00 Cr-Commit-Position: refs/heads/master@{#14079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M tools/gyp_flag_compare.py View 3 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-05 15:27:12 UTC) #2
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-09-05 18:23:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2310983002/1
4 years, 3 months ago (2016-09-06 06:10:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 06:19:49 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 06:19:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b1b472c511172a8189e7f81a1aec07ac35a2e00
Cr-Commit-Position: refs/heads/master@{#14079}

Powered by Google App Engine
This is Rietveld 408576698