Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2310973003: MB: Cleanup no-longer-used GN configurations (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Cleanup no-longer-used GN configurations These were used in the transition from GN->GYP. NOTRY=True BUG=webrtc:5949 Committed: https://crrev.com/dedc822830f9013927afb9bf36acd03d2fc859cf Cr-Commit-Position: refs/heads/master@{#14087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M webrtc/build/mb_config.pyl View 10 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
4 years, 3 months ago (2016-09-06 09:23:52 UTC) #2
ehmaldonado_webrtc
On 2016/09/06 09:23:52, kjellander_webrtc wrote: lgtm
4 years, 3 months ago (2016-09-06 09:28:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2310973003/1
4 years, 3 months ago (2016-09-06 09:31:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 09:32:35 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 09:32:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dedc822830f9013927afb9bf36acd03d2fc859cf
Cr-Commit-Position: refs/heads/master@{#14087}

Powered by Google App Engine
This is Rietveld 408576698