Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: webrtc/modules/desktop_capture/screen_drawer_unittest.cc

Issue 2310953002: Revert of [WebRTC] A real ScreenCapturer test (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/screen_drawer_unittest.cc
diff --git a/webrtc/modules/desktop_capture/screen_drawer_unittest.cc b/webrtc/modules/desktop_capture/screen_drawer_unittest.cc
index b5f6ba5c1be2712ce2d734d7f941575c15aaca79..345a962223ebdc4a670ca6f0c88b076d9bd2375b 100644
--- a/webrtc/modules/desktop_capture/screen_drawer_unittest.cc
+++ b/webrtc/modules/desktop_capture/screen_drawer_unittest.cc
@@ -15,7 +15,6 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "webrtc/base/random.h"
#include "webrtc/base/timeutils.h"
-#include "webrtc/system_wrappers/include/logging.h"
#include "webrtc/system_wrappers/include/sleep.h"
namespace webrtc {
@@ -27,16 +26,11 @@
TEST(ScreenDrawerTest, DISABLED_DrawRectangles) {
std::unique_ptr<ScreenDrawer> drawer = ScreenDrawer::Create();
if (!drawer) {
- LOG(LS_WARNING) << "No ScreenDrawer implementation for current platform.";
+ // No ScreenDrawer implementation for current platform.
return;
}
- if (drawer->DrawableRegion().is_empty()) {
- LOG(LS_WARNING) << "ScreenDrawer of current platform does not provide a "
- "non-empty DrawableRegion().";
- return;
- }
-
+ drawer->Clear();
DesktopRect rect = drawer->DrawableRegion();
Random random(rtc::TimeMicros());
for (int i = 0; i < 100; i++) {
@@ -46,15 +40,16 @@
drawer->DrawRectangle(
DesktopRect::MakeLTRB(left, top, random.Rand(left + 1, rect.right()),
random.Rand(top + 1, rect.bottom())),
- RgbaColor(random.Rand<uint8_t>(), random.Rand<uint8_t>(),
- random.Rand<uint8_t>(), random.Rand<uint8_t>()));
+ random.Rand<uint32_t>());
if (i == 50) {
SleepMs(10000);
+ drawer->Clear();
}
}
SleepMs(10000);
+ drawer->Clear();
}
} // namespace webrtc
« no previous file with comments | « webrtc/modules/desktop_capture/screen_drawer_linux.cc ('k') | webrtc/modules/desktop_capture/screen_drawer_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698