Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2310953002: Revert of [WebRTC] A real ScreenCapturer test (Closed)

Created:
4 years, 3 months ago by åsapersson
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of [WebRTC] A real ScreenCapturer test (patchset #8 id:240001 of https://codereview.webrtc.org/2268093002/ ) Reason for revert: ScreenCapturerTest.CaptureUpdatedRegion fails on Win DrMemory Full. Original issue's description: > [WebRTC] A real ScreenCapturer test > > We do not have a real ScreenCapturer test before. And after CL 2210443002, a new > ScreenDrawer interface is added to the code base to draw various shapes on the > screen. This change is to use ScreenDrawer to test ScreenCapturer. Besides test > cases, some other changes are included, > > 1. A WaitForPendingPaintings() function in ScreenDrawer, to wait for a > ScreenDrawer to finish all the pending draws. This function now only sleeps 50 > milliseconds on X11 and 100 milliseconds on Windows. > > 2. A Color structure to help handle a big-endian or little-endian safe color and > provide functions to compare with DesktopFrame::data(). Both ScreenDrawer and > DesktopFrameGenerator (in change 2202443002) can use this class to create colors > and compare with or paint to a DesktopFrame. > > 3. ScreenDrawer now uses Color structure instead of uint32_t. > > BUG=314516 > > TBR=kjellander@chromium.org > > Committed: https://crrev.com/9d1c54ace0dc9f68da0152aa1ded2a8dba0a43ae > Cr-Commit-Position: refs/heads/master@{#14058} TBR=sergeyu@chromium.org,jamiewalch@chromium.org,kjellander@chromium.org,zijiehe@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=314516 Committed: https://crrev.com/4c44202dc348613695a4b529bbd7c9bdab6195ec Cr-Commit-Position: refs/heads/master@{#14071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -400 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/desktop_capture/rgba_color.h View 1 chunk +0 lines, -54 lines 0 comments Download
D webrtc/modules/desktop_capture/rgba_color.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_unittest.cc View 9 chunks +16 lines, -153 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_drawer.h View 1 chunk +9 lines, -19 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_drawer_linux.cc View 5 chunks +24 lines, -52 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_drawer_unittest.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_drawer_win.cc View 5 chunks +12 lines, -60 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
åsapersson
Created Revert of [WebRTC] A real ScreenCapturer test
4 years, 3 months ago (2016-09-05 12:45:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2310953002/1
4 years, 3 months ago (2016-09-05 12:45:34 UTC) #3
kjellander_webrtc
On 2016/09/05 12:45:34, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 3 months ago (2016-09-05 13:02:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 13:55:22 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c44202dc348613695a4b529bbd7c9bdab6195ec Cr-Commit-Position: refs/heads/master@{#14071}
4 years, 3 months ago (2016-09-05 13:55:33 UTC) #7
Hzj_jie
4 years, 3 months ago (2016-09-05 21:25:25 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2313653003/ by zijiehe@chromium.org.

The reason for reverting is: Resubmit capturer tests.

Powered by Google App Engine
This is Rietveld 408576698