Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc

Issue 2310943002: Add time line for acked bitrate. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc b/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc
index 217307b86c701c1c85b0f62655097110b80b023b..d7067b3ef8eb10eea02c41995ccd48df410cb25a 100644
--- a/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc
+++ b/webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc
@@ -70,7 +70,7 @@ void TransportFeedbackAdapter::OnSentPacket(uint16_t sequence_number,
send_time_history_.OnSentPacket(sequence_number, send_time_ms);
}
-const std::vector<PacketInfo> TransportFeedbackAdapter::GetPacketFeedbackVector(
+std::vector<PacketInfo> TransportFeedbackAdapter::GetPacketFeedbackVector(
const rtcp::TransportFeedback& feedback) {
int64_t timestamp_us = feedback.GetBaseTimeUs();
// Add timestamp deltas to a local time base selected on first packet arrival.
@@ -130,10 +130,15 @@ const std::vector<PacketInfo> TransportFeedbackAdapter::GetPacketFeedbackVector(
void TransportFeedbackAdapter::OnTransportFeedback(
const rtcp::TransportFeedback& feedback) {
- const std::vector<PacketInfo> packet_feedback_vector =
- GetPacketFeedbackVector(feedback);
- RTC_DCHECK(bitrate_estimator_.get() != nullptr);
- bitrate_estimator_->IncomingPacketFeedbackVector(packet_feedback_vector);
+ last_packet_feedback_vector_ = GetPacketFeedbackVector(feedback);
+ if (bitrate_estimator_.get())
+ bitrate_estimator_->IncomingPacketFeedbackVector(
+ last_packet_feedback_vector_);
+}
+
+std::vector<PacketInfo> TransportFeedbackAdapter::GetTransportFeedbackVector()
+ const {
+ return last_packet_feedback_vector_;
}
void TransportFeedbackAdapter::OnReceiveBitrateChanged(

Powered by Google App Engine
This is Rietveld 408576698