Add time line for acked bitrate.

Add time line for acked bitrate.

R=philipel@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/60e43469550d113bc123fa99d2767575af4e1ddd

[stefan-webrtc, 2016-09-05 12:41:09]

stefan@webrtc.org changed reviewers:
+ philipel@webrtc.org

[philipel, 2016-09-05 13:30:05]

https://codereview.webrtc.org/2310943002/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2310943002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:830:
cc.GetTransportFeedbackObserver()->OnTransportFeedback(
I think it's cleaner if you call both
TransportFeedbackAdapted::OnTransportFeedback to simulate the bwe behavior and
then call TransportFeedbackAdapater::GetPacketFeedbackVector to get the vector
of PacketInfos.

[stefan-webrtc, 2016-09-05 14:03:39]

https://codereview.webrtc.org/2310943002/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2310943002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:830:
cc.GetTransportFeedbackObserver()->OnTransportFeedback(
On 2016/09/05 13:30:05, philipel wrote:
> I think it's cleaner if you call both
> TransportFeedbackAdapted::OnTransportFeedback to simulate the bwe behavior and
> then call TransportFeedbackAdapater::GetPacketFeedbackVector to get the vector
> of PacketInfos.

Done.

[philipel, 2016-09-05 14:56:25]

https://codereview.webrtc.org/2310943002/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2310943002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:830:
cc.GetTransportFeedbackObserver()->OnTransportFeedback(
On 2016/09/05 14:03:39, stefan-webrtc (holmer) wrote:
> On 2016/09/05 13:30:05, philipel wrote:
> > I think it's cleaner if you call both
> > TransportFeedbackAdapted::OnTransportFeedback to simulate the bwe behavior
and
> > then call TransportFeedbackAdapater::GetPacketFeedbackVector to get the
vector
> > of PacketInfos.
> 
> Done.

Maybe something even cleaner would be to add a GetTransportFeedbackAdapter to
CongestionController.

Then you would only have to change CongestionController and in EventLogAnalyzer
all you have to do is:

TransportFeedbackAdapter* a = cc.GetTransportFeedbackAdapter();
std::vector<PacketInfo> pi =
a->OnTransportFeedback(*static_cast<rtcp::TransportFeedback*>(rtcp.packet.get());
a->GetBitrateEstimator()->IncomingPacketFeedbackVector(pi);

WDYT?

[stefan-webrtc, 2016-09-06 11:53:11]

https://codereview.webrtc.org/2310943002/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2310943002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:830:
cc.GetTransportFeedbackObserver()->OnTransportFeedback(
On 2016/09/05 14:56:25, philipel wrote:
> On 2016/09/05 14:03:39, stefan-webrtc (holmer) wrote:
> > On 2016/09/05 13:30:05, philipel wrote:
> > > I think it's cleaner if you call both
> > > TransportFeedbackAdapted::OnTransportFeedback to simulate the bwe behavior
> and
> > > then call TransportFeedbackAdapater::GetPacketFeedbackVector to get the
> vector
> > > of PacketInfos.
> > 
> > Done.
> 
> Maybe something even cleaner would be to add a GetTransportFeedbackAdapter to
> CongestionController.
> 
> Then you would only have to change CongestionController and in
EventLogAnalyzer
> all you have to do is:
> 
> TransportFeedbackAdapter* a = cc.GetTransportFeedbackAdapter();
> std::vector<PacketInfo> pi =
>
a->OnTransportFeedback(*static_cast<rtcp::TransportFeedback*>(rtcp.packet.get());
> a->GetBitrateEstimator()->IncomingPacketFeedbackVector(pi);
> 
> WDYT?

I want to get rid of the GetBitrateEstimator() api (and at some point also
GetTransportFeedbackObserver()), so I want to rely as little as possible on
those.

[philipel, 2016-09-06 12:16:17]

lgtm

[stefan-webrtc, 2016-09-06 12:25:10]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-09-06 12:25:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-06 12:28:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 12:28:07]

Try jobs failed on following builders:
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/17801)

[stefan-webrtc, 2016-09-06 13:19:09]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2016-09-06 13:19:09]

The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2310943002/#ps60001 (title:
".")

[commit-bot: I haz the power, 2016-09-06 13:19:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-06 15:19:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 15:20:00]

Try jobs failed on following builders:
  linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[stefan-webrtc, 2016-09-07 07:57:57]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-09-07 07:58:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 07:58:35]

Description was changed from

==========
Add time line for acked bitrate.
==========

to

==========
Add time line for acked bitrate.

R=philipel@webrtc.org

Committed: https://crrev.com/60e43469550d113bc123fa99d2767575af4e1ddd
Cr-Commit-Position: refs/heads/master@{#14098}
==========

[stefan-webrtc, 2016-09-07 07:58:35]

Description was changed from

==========
Add time line for acked bitrate.
==========

to

==========
Add time line for acked bitrate.

R=philipel@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/60e43469550d113bc123fa99d...
==========

[commit-bot: I haz the power, 2016-09-07 07:58:36]

Patchset 4 (id:??) landed as
https://crrev.com/60e43469550d113bc123fa99d2767575af4e1ddd
Cr-Commit-Position: refs/heads/master@{#14098}

[stefan-webrtc, 2016-09-07 07:58:37]

Committed patchset #4 (id:60001) manually as
60e43469550d113bc123fa99d2767575af4e1ddd (presubmit successful).