Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2310403002: Renamed and restructured the protobuf definitions for the rtc_event_log graphs. (Closed)

Created:
4 years, 3 months ago by skvlad
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renamed and restructured the protobuf definitions for the rtc_event_log graphs. BUG= Committed: https://crrev.com/f581eb76f46085beb69b8095e1cff75ce98aab52 Cr-Commit-Position: refs/heads/master@{#14112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -59 lines) Patch
M webrtc/tools/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
A webrtc/tools/event_log_visualizer/chart.proto View 1 chunk +36 lines, -0 lines 0 comments Download
D webrtc/tools/event_log_visualizer/graph.proto View 1 chunk +0 lines, -32 lines 0 comments Download
M webrtc/tools/event_log_visualizer/plot_protobuf.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/tools/event_log_visualizer/plot_protobuf.cc View 2 chunks +19 lines, -17 lines 0 comments Download
M webrtc/tools/tools.gyp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
skvlad
4 years, 3 months ago (2016-09-07 03:37:48 UTC) #2
skvlad
4 years, 3 months ago (2016-09-07 17:37:06 UTC) #4
stefan-webrtc
Assuming terelius fine with this. lgtm
4 years, 3 months ago (2016-09-07 17:52:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2310403002/1
4 years, 3 months ago (2016-09-07 18:09:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 18:15:40 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f581eb76f46085beb69b8095e1cff75ce98aab52 Cr-Commit-Position: refs/heads/master@{#14112}
4 years, 3 months ago (2016-09-07 18:15:53 UTC) #11
kjellander_webrtc
4 years, 3 months ago (2016-09-07 19:09:42 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698