Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: webrtc/tools/py_event_log_analyzer/pb_parse.py

Issue 2310063002: Improvements to UI to python event log analyzer tool. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/tools/py_event_log_analyzer/misc.py ('k') | webrtc/tools/py_event_log_analyzer/rtp_analyzer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/py_event_log_analyzer/pb_parse.py
diff --git a/webrtc/tools/py_event_log_analyzer/pb_parse.py b/webrtc/tools/py_event_log_analyzer/pb_parse.py
index b0ca2b3354463a76e5f932758e21c580eedb6f43..8062c438e67c564c743d8dc2d7f20ed378722604 100644
--- a/webrtc/tools/py_event_log_analyzer/pb_parse.py
+++ b/webrtc/tools/py_event_log_analyzer/pb_parse.py
@@ -17,13 +17,14 @@ class DataPoint(object):
"""Simple container class for RTP events."""
def __init__(self, rtp_header_str, packet_size,
- arrival_timestamp_us):
+ arrival_timestamp_us, incoming):
"""Builds a data point by parsing an RTP header, size and arrival time.
RTP header structure is defined in RFC 3550 section 5.1.
"""
self.size = packet_size
self.arrival_timestamp_ms = arrival_timestamp_us / 1000
+ self.incoming = incoming
header = struct.unpack_from("!HHII", rtp_header_str, 0)
(first2header_bytes, self.sequence_number, self.timestamp,
self.ssrc) = header
@@ -44,8 +45,8 @@ def parse_protobuf(file_path):
with open(file_path, "rb") as f:
event_stream.ParseFromString(f.read())
- return [DataPoint(event.rtp_packet.header,
- event.rtp_packet.packet_length,
- event.timestamp_us)
- for event in event_stream.stream
- if event.HasField("rtp_packet")]
+ return [DataPoint(event.rtp_packet.header,
phoglund 2016/09/06 13:14:50 Nit: remove extra space
+ event.rtp_packet.packet_length,
+ event.timestamp_us, event.rtp_packet.incoming)
+ for event in event_stream.stream
+ if event.HasField("rtp_packet")]
« no previous file with comments | « webrtc/tools/py_event_log_analyzer/misc.py ('k') | webrtc/tools/py_event_log_analyzer/rtp_analyzer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698