Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2310063002: Improvements to UI to python event log analyzer tool. (Closed)

Created:
4 years, 3 months ago by aleloi
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improvements to UI to python event log analyzer tool. SSRCs are now filtered by incoming and outgoing. NOTRY=True Committed: https://crrev.com/eb24dd01be7c9672e1db1d72ea3a16f324e2d7ac Cr-Commit-Position: refs/heads/master@{#14092}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed space. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M webrtc/tools/py_event_log_analyzer/misc.py View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/tools/py_event_log_analyzer/pb_parse.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/tools/py_event_log_analyzer/rtp_analyzer.py View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
aleloi
Requested feature implemented. Now incoming and outgoing SSRCs are grouped together. The ssrc selection now ...
4 years, 3 months ago (2016-09-06 11:30:55 UTC) #3
hlundin-webrtc
lgtm
4 years, 3 months ago (2016-09-06 13:05:41 UTC) #4
phoglund
lgtm https://codereview.webrtc.org/2310063002/diff/1/webrtc/tools/py_event_log_analyzer/pb_parse.py File webrtc/tools/py_event_log_analyzer/pb_parse.py (right): https://codereview.webrtc.org/2310063002/diff/1/webrtc/tools/py_event_log_analyzer/pb_parse.py#newcode48 webrtc/tools/py_event_log_analyzer/pb_parse.py:48: return [DataPoint(event.rtp_packet.header, Nit: remove extra space
4 years, 3 months ago (2016-09-06 13:14:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2310063002/20001
4 years, 3 months ago (2016-09-06 13:25:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 13:34:20 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 13:34:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb24dd01be7c9672e1db1d72ea3a16f324e2d7ac
Cr-Commit-Position: refs/heads/master@{#14092}

Powered by Google App Engine
This is Rietveld 408576698