Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: webrtc/modules/video_coding/utility/quality_scaler.h

Issue 2309743002: Move the QP scaling thresholds to the relevant encoders (Closed)
Patch Set: fix namespace issue in videoToolbox encoder Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/utility/quality_scaler.h
diff --git a/webrtc/modules/video_coding/utility/quality_scaler.h b/webrtc/modules/video_coding/utility/quality_scaler.h
index 7176d4966eb46ed93c0506edd061c277d7e3f0e7..8ca659e6538551a5496e15128ef2701b86e9c3ea 100644
--- a/webrtc/modules/video_coding/utility/quality_scaler.h
+++ b/webrtc/modules/video_coding/utility/quality_scaler.h
@@ -38,15 +38,6 @@ class QualityScaler {
const rtc::scoped_refptr<VideoFrameBuffer>& frame);
int downscale_shift() const { return downscale_shift_; }
- // QP is obtained from VP8-bitstream for HW, so the QP corresponds to the
- // bitstream range of [0, 127] and not the user-level range of [0,63].
- static const int kLowVp8QpThreshold;
pbos-webrtc 2016/09/12 19:51:49 I think this might be the best place for the defau
- static const int kBadVp8QpThreshold;
-
- // H264 QP is in the range [0, 51].
- static const int kLowH264QpThreshold;
- static const int kBadH264QpThreshold;
-
private:
void AdjustScale(bool up);
void UpdateTargetResolution(int frame_width, int frame_height);

Powered by Google App Engine
This is Rietveld 408576698