PRESUBMIT.py - Issue 2309253005: Unify the macOS and iOS capturer implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2309253005: Unify the macOS and iOS capturer implementations (Closed)

Patch Set: apple -> objc Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 04de7c8def9392b87b16347e19f00ca00a85aeb1..5101f27e940dea609c20ebbe87d4b45af08127b4 100755

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -499,6 +499,7 @@ def _CommonChecks(input_api, output_api):

# they do not follow C++ lint rules.

black_list = input_api.DEFAULT_BLACK_LIST + (

r".*\bobjc[\\\/].*",

tkchin_webrtc 2016/09/28 09:21:06 probably don't need the first rule anymore then?

+ r".*objc\.[hcm]+$",

r"webrtc\/build\/ios\/SDK\/.*",

)

source_file_filter = lambda x: input_api.FilterSourceFile(x, None, black_list)