GN: Move variables from //build_overrides/webrtc.gni to //webrtc/build/webrtc.gni

GN: Move variables from //build_overrides/webrtc.gni to //webrtc/build/webrtc.gni

There is no clear reason to have them in build_overrides, and
webrtc/build seems to be a better place.

Also, delete build_overrides/webrtc.gni

NOTRY=True
BUG=webrtc:5949
Committed: https://crrev.com/4016a0b2e88c49c8f4966ea56403770b8687255b
Cr-Commit-Position: refs/heads/master@{#14108}

[ehmaldonado_webrtc, 2016-09-06 09:56:35]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2016-09-06 10:36:09]

https://codereview.webrtc.org/2309253004/diff/1/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2309253004/diff/1/webrtc/sdk/BUILD.gn#newcode9
webrtc/sdk/BUILD.gn:9: import("../build/build.gni")
Did you mean to make this //build/build.gni or //build_overrides/build.gni ?

[ehmaldonado_chromium, 2016-09-06 11:32:26]

On 2016/09/06 10:36:09, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2309253004/diff/1/webrtc/sdk/BUILD.gn
> File webrtc/sdk/BUILD.gn (right):
> 
> https://codereview.webrtc.org/2309253004/diff/1/webrtc/sdk/BUILD.gn#newcode9
> webrtc/sdk/BUILD.gn:9: import("../build/build.gni")
> Did you mean to make this //build/build.gni or //build_overrides/build.gni ?

I didn't mean to touch that line at all.
PTAL

[kjellander_webrtc, 2016-09-06 12:19:11]

kjellander@webrtc.org changed reviewers:
+ dpranke@chromium.org

[kjellander_webrtc, 2016-09-06 12:19:11]

Dirk, I don't remember why this wouldn't be preferred - it seems we can drop
build_overrides then.

Was there something else that prevented us from doing this in the past?

[Dirk Pranke, 2016-09-06 15:04:39]

On 2016/09/06 12:19:11, kjellander_webrtc wrote:
> Dirk, I don't remember why this wouldn't be preferred - it seems we can drop
> build_overrides then.
> 
> Was there something else that prevented us from doing this in the past?

If the defaults are all that simple, then there's no reason not to do what this
patch does. Maybe this just never occurred to us.

LGTM.

[kjellander_webrtc, 2016-09-07 06:20:06]

On 2016/09/06 15:04:39, Dirk Pranke wrote:
> On 2016/09/06 12:19:11, kjellander_webrtc wrote:
> > Dirk, I don't remember why this wouldn't be preferred - it seems we can drop
> > build_overrides then.
> > 
> > Was there something else that prevented us from doing this in the past?
> 
> If the defaults are all that simple, then there's no reason not to do what
this
> patch does. Maybe this just never occurred to us.
> 
> LGTM.

Chromium trybots seems happy with PS#3, so I suggest submitting PS#2 (or PS#4 if
you choose to add another one instead).
LGTM

[ehmaldonado_webrtc, 2016-09-07 10:41:39]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-09-07 10:41:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2309253004/#ps60001 (title:
"Delete build_overrides/webrtc.gni")

[commit-bot: I haz the power, 2016-09-07 10:41:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 10:52:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 10:52:21]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16437)

[ehmaldonado_webrtc, 2016-09-07 13:42:11]

Description was changed from

==========
GN: Move variables from //build_overrides/webrtc.gni to
//webrtc/build/webrtc.gni

There is no clear reason to have them in build_overrides, and
webrtc/build seems to be a better place.

Also, delete build_overrides/webrtc.gni

BUG=webrtc:5949
==========

to

==========
GN: Move variables from //build_overrides/webrtc.gni to
//webrtc/build/webrtc.gni

There is no clear reason to have them in build_overrides, and
webrtc/build seems to be a better place.

Also, delete build_overrides/webrtc.gni

NOTRY=True
BUG=webrtc:5949
==========

[ehmaldonado_webrtc, 2016-09-07 13:42:16]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-09-07 13:42:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 13:50:21]

Description was changed from

==========
GN: Move variables from //build_overrides/webrtc.gni to
//webrtc/build/webrtc.gni

There is no clear reason to have them in build_overrides, and
webrtc/build seems to be a better place.

Also, delete build_overrides/webrtc.gni

NOTRY=True
BUG=webrtc:5949
==========

to

==========
GN: Move variables from //build_overrides/webrtc.gni to
//webrtc/build/webrtc.gni

There is no clear reason to have them in build_overrides, and
webrtc/build seems to be a better place.

Also, delete build_overrides/webrtc.gni

NOTRY=True
BUG=webrtc:5949
==========

[commit-bot: I haz the power, 2016-09-07 13:50:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-07 13:50:25]

Description was changed from

==========
GN: Move variables from //build_overrides/webrtc.gni to
//webrtc/build/webrtc.gni

There is no clear reason to have them in build_overrides, and
webrtc/build seems to be a better place.

Also, delete build_overrides/webrtc.gni

NOTRY=True
BUG=webrtc:5949
==========

to

==========
GN: Move variables from //build_overrides/webrtc.gni to
//webrtc/build/webrtc.gni

There is no clear reason to have them in build_overrides, and
webrtc/build seems to be a better place.

Also, delete build_overrides/webrtc.gni

NOTRY=True
BUG=webrtc:5949

Committed: https://crrev.com/4016a0b2e88c49c8f4966ea56403770b8687255b
Cr-Commit-Position: refs/heads/master@{#14108}
==========

[commit-bot: I haz the power, 2016-09-07 13:50:25]

Patchset 4 (id:??) landed as
https://crrev.com/4016a0b2e88c49c8f4966ea56403770b8687255b
Cr-Commit-Position: refs/heads/master@{#14108}