Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2308553002: GN Templates: Add //build/config/sanitizers:deps to rtc_executable. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, henrika_webrtc, zhuangzesen_agora.io, Andrew MacDonald, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, minyue-webrtc, the sun, mflodman, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN Templates: Add //build/config/sanitizers:deps to rtc_executable. Remove //build/config/sanitizers:deps as a dependency for all rtc_executable targets and add it to the template instead. BUG=webrtc:6187 NOTRY=True Committed: https://crrev.com/1dd23350234d606457bebdb28eb3eb9b2bc83d1e Cr-Commit-Position: refs/heads/master@{#14048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -43 lines) Patch
M webrtc/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/build/webrtc.gni View 3 chunks +6 lines, -0 lines 0 comments Download
M webrtc/examples/BUILD.gn View 5 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 22 chunks +0 lines, -22 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 8 chunks +0 lines, -8 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-02 11:37:58 UTC) #5
kjellander_webrtc
Excellent. Making life easier for everyone. Run a few compile trybots and use NOTRY=True to ...
4 years, 3 months ago (2016-09-02 12:00:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2308553002/20001
4 years, 3 months ago (2016-09-02 13:40:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-02 14:03:18 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 14:03:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dd23350234d606457bebdb28eb3eb9b2bc83d1e
Cr-Commit-Position: refs/heads/master@{#14048}

Powered by Google App Engine
This is Rietveld 408576698