Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2308183002: Increase timeout for flaky tests for ProcessThreadImpl (Closed)

Created:
4 years, 3 months ago by skvlad
Modified:
4 years, 3 months ago
Reviewers:
perkj_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increase timeout for flaky tests for ProcessThreadImpl These tests were waiting for a thread to start in 100 ms. This seems to be not enough on some Windows bots, as there were multiple failures recently: https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug/builds/9188/steps/modules_unittests/logs/stdio https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug/builds/8794/steps/modules_unittests/logs/stdio I have increased the timeout to 500 ms. This will not make successful test runs slower, but will reduce the chance of a spurious failure. R=perkj@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/b460fd8b1678a7a705148692fba15613a12d9061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 6 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
skvlad
4 years, 3 months ago (2016-09-03 00:24:51 UTC) #2
perkj_webrtc
lgtm
4 years, 3 months ago (2016-09-04 13:05:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2308183002/1
4 years, 3 months ago (2016-09-06 17:32:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-06 19:32:38 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b460fd8b1678a7a705148692fba15613a12d9061 Cr-Commit-Position: refs/heads/master@{#14096}
4 years, 3 months ago (2016-09-06 21:34:44 UTC) #9
skvlad
4 years, 3 months ago (2016-09-06 21:34:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b460fd8b1678a7a705148692fba15613a12d9061 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698