Fix chromium-style errors in IntelligibilityEnhancer

Fix chromium-style errors in IntelligibilityEnhancer

BUG=
R=henrik.lundin@webrtc.org, peah@webrtc.org

Committed: https://crrev.com/37062ed16ff82de73cc6b4f9e71a60afe67d3166
Cr-Commit-Position: refs/heads/master@{#14094}

[aluebs-webrtc, 2016-09-02 18:25:34]

aluebs@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, peah@webrtc.org

[aluebs-webrtc, 2016-09-02 18:25:35]

This is a clear example of why ifdeffing out code without enabling it anywhere
can generate problems. While the IE has been removed from all bots a new
chromium-style rule has been enforced and now it doesn't compile. Can we please
reconsider? I don't think that the IE is the only feature behind a
media-constraint that could potentially generate an issue if enabled in the
wrong conditions. We always assumed a user who touches the media-constraints
knows what they are doing. And if this is about binary size, memory footprint or
complexity (when disabled), then it would be good to study this compared to the
cost of code bloating, increased testing complications and less coverage. I
think that at least there should be some bots running this config. WDYT?

[peah-webrtc, 2016-09-03 09:34:04]

On 2016/09/02 18:25:35, aluebs-webrtc wrote:
> This is a clear example of why ifdeffing out code without enabling it anywhere
> can generate problems. While the IE has been removed from all bots a new
> chromium-style rule has been enforced and now it doesn't compile. Can we
please
> reconsider? I don't think that the IE is the only feature behind a
> media-constraint that could potentially generate an issue if enabled in the
> wrong conditions. We always assumed a user who touches the media-constraints
> knows what they are doing. And if this is about binary size, memory footprint
or
> complexity (when disabled), then it would be good to study this compared to
the
> cost of code bloating, increased testing complications and less coverage. I
> think that at least there should be some bots running this config. WDYT?

lgtm for the changes
Regarding the other topics brought up I don't think they belong to this CL and
should instead be discussed in another forum.

[hlundin-webrtc, 2016-09-06 10:44:25]

LGTM.

Let's discuss #ifdefs offline.

[aluebs-webrtc, 2016-09-06 16:13:48]

The CQ bit was checked by aluebs@webrtc.org

[commit-bot: I haz the power, 2016-09-06 16:13:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-06 18:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 18:15:09]

Try jobs failed on following builders:
  linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[aluebs-webrtc, 2016-09-06 18:25:53]

Description was changed from

==========
Fix chromium-style errors in IntelligibilityEnhancer

BUG=
==========

to

==========
Fix chromium-style errors in IntelligibilityEnhancer

BUG=
R=henrik.lundin@webrtc.org, peah@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/37062ed16ff82de73cc6b4f9e...
==========

[aluebs-webrtc, 2016-09-06 18:25:54]

Committed patchset #1 (id:1) manually as
37062ed16ff82de73cc6b4f9e71a60afe67d3166 (presubmit successful).

[commit-bot: I haz the power, 2016-09-06 18:25:57]

Description was changed from

==========
Fix chromium-style errors in IntelligibilityEnhancer

BUG=
R=henrik.lundin@webrtc.org, peah@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/37062ed16ff82de73cc6b4f9e...
==========

to

==========
Fix chromium-style errors in IntelligibilityEnhancer

BUG=
R=henrik.lundin@webrtc.org, peah@webrtc.org

Committed: https://crrev.com/37062ed16ff82de73cc6b4f9e71a60afe67d3166
Cr-Commit-Position: refs/heads/master@{#14094}
==========