Fixed flaky VideoSendStreamTest::SupportsAbsoluteSendTime

webrtc/video/video_send_stream_tests.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #include <algorithm>  // max
@@ skipping 118 matching lines @@
           kRtpExtensionAbsoluteSendTime, test::kAbsSendTimeExtensionId));
     }
 
     Action OnSendRtp(const uint8_t* packet, size_t length) override {
       RTPHeader header;
       EXPECT_TRUE(parser_->Parse(packet, length, &header));
 
       EXPECT_FALSE(header.extension.hasTransmissionTimeOffset);
       EXPECT_TRUE(header.extension.hasAbsoluteSendTime);
       EXPECT_EQ(header.extension.transmissionTimeOffset, 0);
-      EXPECT_GT(header.extension.absoluteSendTime, 0u);

[pbos-webrtc, 2016/09/01 23:06:22]

How about returning SEND_PACKET if absoluteSendTime is non-zero and wait for the
next one to arrive instead (and log a warning, so that you can see why (through
repeated logging) if the test times out)?

[pbos-webrtc, 2016/09/01 23:06:49]

Sorry, return SEND_PACKET early if it's zero, not non-zero.

[skvlad, 2016/09/01 23:39:28]

Done.

       observation_complete_.Set();
 
       return SEND_PACKET;
     }
 
     void ModifyVideoConfigs(
         VideoSendStream::Config* send_config,
         std::vector<VideoReceiveStream::Config>* receive_configs,
         VideoEncoderConfig* encoder_config) override {
       send_config->rtp.extensions.clear();
@@ skipping 2375 matching lines @@
         observation_complete_.Set();
       }
     }
   } test;
 
   RunBaseTest(&test);
 }
 #endif  // !defined(RTC_DISABLE_VP9)
 
 }  // namespace webrtc